script: Generate more correct HTML for underline command#44331
Merged
Conversation
This makes further steps to generate the correct HTML. Some tests now have more appropriate HTML, but are not fully passing yet as they require more fixes. I also missed the fact that there is actually an algorithm to set the tag name, which I thought didn't exist. Therefore, also correctly implement that. Part of servo#25005 Signed-off-by: Tim van der Lippe <tvanderlippe@gmail.com>
feef762 to
db704db
Compare
jdm
approved these changes
Apr 18, 2026
Signed-off-by: Tim van der Lippe <TimvdLippe@users.noreply.github.com>
….ini Signed-off-by: Tim van der Lippe <TimvdLippe@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes further steps to generate the correct HTML. Some tests now have more appropriate HTML, but are not fully passing yet as they require more fixes. I also missed the fact that there is actually an algorithm to set the tag name, which I thought didn't exist. Therefore, also correctly implement that.
Part of #25005
Testing: WPT