Skip to content

media: Switch to workspace dependencies and minor cleanup#44428

Merged
TimvdLippe merged 3 commits into
servo:mainfrom
Narfinger:servo-media-cargo-toml
Apr 22, 2026
Merged

media: Switch to workspace dependencies and minor cleanup#44428
TimvdLippe merged 3 commits into
servo:mainfrom
Narfinger:servo-media-cargo-toml

Conversation

@Narfinger

@Narfinger Narfinger commented Apr 22, 2026

Copy link
Copy Markdown
Contributor

This PR makes minor cleanup in the media crates:

  • Switch dependencies to workspace dependencies if they are already included in the main Cargo.toml
  • Switch from crate serde_derive to serde with feature flag derive.
  • Switch from the separate crate for OnceCell to the std provided LazyLock.
  • Update num_complex

Testing: The only functional changes are either slight version bumps, the replacement to LazyLock which is conservative and the num_complex update which also shouldn't have any behavior changes.

@servo-highfive servo-highfive added the S-awaiting-review There is new code that needs to be reviewed. label Apr 22, 2026
mrobinson
mrobinson approved these changes Apr 22, 2026
View reviewed changes

@mrobinson mrobinson left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Comment thread components/media/audio/Cargo.toml Outdated
Comment thread components/media/backends/gstreamer/media_stream_source.rs Outdated
Comment thread components/media/backends/ohos/Cargo.toml Outdated
@servo-highfive servo-highfive added S-awaiting-review There is new code that needs to be reviewed. and removed S-awaiting-review There is new code that needs to be reviewed. labels Apr 22, 2026
@Narfinger

Narfinger commented Apr 22, 2026

Copy link
Copy Markdown
Contributor Author

For completeness sake I added rayon feature to yuv as we already have a rayon pool running.

@Narfinger Narfinger force-pushed the servo-media-cargo-toml branch from 0dd456a to 1577d4d Compare April 22, 2026 12:02
@Narfinger
switch to workspace and other stuff
fd860b4 
Signed-off-by: Narfinger <Narfinger@users.noreply.github.com>
@Narfinger
incorporate suggestions
1577d4d 
Signed-off-by: Narfinger <Narfinger@users.noreply.github.com>
@TimvdLippe TimvdLippe added this pull request to the merge queue Apr 22, 2026
@servo-highfive servo-highfive added the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Apr 22, 2026
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Apr 22, 2026
@servo-highfive servo-highfive added S-tests-failed The changes caused existing tests to fail. and removed S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. S-tests-failed The changes caused existing tests to fail. labels Apr 22, 2026
@Narfinger
fix ohos compile
24eab25 
Signed-off-by: Narfinger <Narfinger@users.noreply.github.com>
@TimvdLippe TimvdLippe added this pull request to the merge queue Apr 22, 2026
@servo-highfive servo-highfive added the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Apr 22, 2026
Merged via the queue into servo:main with commit c2b88ff Apr 22, 2026
30 checks passed
@servo-highfive servo-highfive removed the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Apr 22, 2026
@Narfinger Narfinger deleted the servo-media-cargo-toml branch April 22, 2026 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mrobinson mrobinson mrobinson approved these changes

Assignees

No one assigned

Labels

S-awaiting-review There is new code that needs to be reviewed.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Narfinger @mrobinson @TimvdLippe @servo-highfive