App crashes on reload in development mode with JSC Engine

[ykliuiev]

Description

After upgrading to react-native-reanimated v3, we noticed that app crashes on reload in development mode with JSC engine. It's reproducible in Example/ app in react-native-reanimated repo and can confirm it does not happen with hermes engine enabled.

Steps to reproduce

1. Disable hermes in Example/ios/Podfile file by changing
   :hermes_enabled => flags[:hermes_enabled], :fabric_enabled => flags[:fabric_enabled],
   to
   :hermes_enabled => false, :fabric_enabled => false,
2. reinstall pods by running pod install command from Example/ios folder
3. build the app and launch it
4. reload the app with R or devmode

Thank you :raised:

Snack or a link to a repository

https://github.com/ykliuiev/reanimated-crash-repro

Reanimated version

3.3.0

React Native version

0.72.3

Platforms

iOS

JavaScript runtime

JSC

Workflow

React Native (without Expo)

Architecture

Paper (Old Architecture)

Build type

Debug mode

Device

iOS simulator

Device model

No response

Acknowledgements

Yes

[victor-asdf]

Same here #4778

[ykliuiev]

@victor-asdf yes, looks like the same but we identified that the root cause is JSC runtime which should help narrow down the potential scope for debugging and investigation.

[victor-asdf]

@ykliuiev Thanks. I have tried all versions of 3.x and it seems happen all the time

[TheMakerOleguch]

@tomekzaw cc

[rajrao1]

iOS App is crashing in iOS 16.5.1 & above in during first launch in Real Device. Not found in the older iOS version.

When:
During first launch of the App after installation. Second launch onwards, no crash.
It is an intermittent crash and does not happen every first time launch of the app after installation.

OS version: iOS 16.5.1 & above. Not seen in below version
react-native-reanimated version: 3.1.0
React Native version: 0.71.7
React Native Type: React Native CLI based app.
iPhone: Reproduced in iPhone 13 Pro Max, iPhone 14 Pro Max, iPhone 12, iPhone XR

Podfile changes:
Below Podfile changes done to support react-native-firebase library

use_frameworks! :linkage => :static // use static frameworks
:hermes_enabled => flags[:hermes_enabled], // No change
:fabric_enabled => false // fabric disabled
#:flipper_configuration => flipper_config, // filpper commented

Crash Log:

Crashed: com.facebook.react.JavaScript
0 xy_app 0x1bd800 reanimated::ShareableRemoteFunction::~ShareableRemoteFunction() + 409 (jsi.h:409)
1 xy_app 0x1b9b98 std::__1::shared_ptrreanimated::ShareableRemoteFunction::~shared_ptrabi:v15006 + 216 (shared_ptr.h:216)
2 xy_app 0x1baf38 std::__1::__function::__func<reanimated::NativeReanimatedModule::NativeReanimatedModule(std::__1::shared_ptrfacebook::react::CallInvoker const&, std::__1::shared_ptrreanimated::Scheduler const&, std::__1::shared_ptrfacebook::jsi::Runtime const&, std::__1::shared_ptrreanimated::ErrorHandler const&, std::__1::function<facebook::jsi::Value (facebook::jsi::Runtime&, int, facebook::jsi::String const&)>, reanimated::PlatformDepMethodsHolder)::$_1::operator()(facebook::jsi::Runtime&, facebook::jsi::Value const&, facebook::jsi::Value const&) const::'lambda'(), std::__1::allocator<reanimated::NativeReanimatedModule::NativeReanimatedModule(std::__1::shared_ptrfacebook::react::CallInvoker const&, std::__1::shared_ptrreanimated::Scheduler const&, std::__1::shared_ptrfacebook::jsi::Runtime const&, std::__1::shared_ptrreanimated::ErrorHandler const&, std::__1::function<facebook::jsi::Value (facebook::jsi::Runtime&, int, facebook::jsi::String const&)>, reanimated::PlatformDepMethodsHolder)::$_1::operator()(facebook::jsi::Runtime&, facebook::jsi::Value const&, facebook::jsi::Value const&) const::'lambda'()>, void ()>::destroy_deallocate() + 256 (new:256)
3 xy_app 0x279d94 std::__1::__function::__func<facebook::react::Instance::JSCallInvoker::scheduleAsync(std::__1::function<void ()>&&)::$_3, std::__1::allocator<facebook::react::Instance::JSCallInvoker::scheduleAsync(std::__1::function<void ()>&&)::$_3>, void (facebook::react::JSExecutor*)>::destroy_deallocate() + 256 (new:256)
4 xy_app 0x283f50 std::__1::__function::__alloc_func<facebook::react::NativeToJsBridge::runOnExecutorQueue(std::__1::function<void (facebook::react::JSExecutor*)>)::$_8, std::__1::allocator<facebook::react::NativeToJsBridge::runOnExecutorQueue(std::__1::function<void (facebook::react::JSExecutor*)>)::$_8>, void ()>::destroyabi:v15006 + 300 (NativeToJsBridge.cpp:300)
5 xy_app 0x283d9c std::__1::__function::__func<facebook::react::NativeToJsBridge::runOnExecutorQueue(std::__1::function<void (facebook::react::JSExecutor*)>)::$_8, std::__1::allocator<facebook::react::NativeToJsBridge::runOnExecutorQueue(std::__1::function<void (facebook::react::JSExecutor*)>)::$_8>, void ()>::destroy_deallocate() + 256 (new:256)
6 xy_app 0x218830 std::__1::shared_ptr<std::__1::function<void ()>>::~shared_ptrabi:v15006 + 216 (shared_ptr.h:216)
7 xy_app 0x218c4c std::__1::__function::__func<facebook::react::RCTMessageThread::runOnQueue(std::__1::function<void ()>&&)::$_1, std::__1::allocator<facebook::react::RCTMessageThread::runOnQueue(std::__1::function<void ()>&&)::$_1>, void ()>::destroy_deallocate() + 700 (shared_ptr.h:700)
8 libsystem_blocks.dylib 0x2134 _call_dispose_helpers_excp + 48
9 libsystem_blocks.dylib 0x1d64 _Block_release + 252
10 CoreFoundation 0xaa238 __CFRunLoopDoBlocks + 404
11 CoreFoundation 0x7a0e8 __CFRunLoopRun + 848
12 CoreFoundation 0x7f3ec CFRunLoopRunSpecific + 612
13 xy_app 0x201fb4 +[RCTCxxBridge runRunLoop] + 336 (RCTCxxBridge.mm:336)
14 Foundation 0x5b544 NSThread__start + 716
15 libsystem_pthread.dylib 0x16b8 _pthread_start + 148xy_app
16 libsystem_pthread.dylib 0xb88 thread_start + 8

[Audrey-Ann]

Same here! The app crashes whenever we reload the app in development mode and when hermes = false :(

react-native: ^0.72.3
react-native-reanimated: ^3.3.0

[ykliuiev]

added simple repro just in case https://github.com/ykliuiev/reanimated-crash-repro

[maydersonmellops]

Same here 1464

[DaniyarJakupov]

Crash also happens (ios only) when doing a codepush update in the production app since it reloads the app in order to apply a new bundle. Would be great to at least get a workaround or a patch.
cc @piaskowyk