⬆️ bundler 2.3.15#65
Merged
Merged
Conversation
Owner
|
Since there’s a RuboCop version bump included, can you fix the new issues with it? 🙏🏻 It looks like they can be fixed by simply calling: bin/rubocop -A |
- Fixes sunny#64: deprecation warnings - Gem updates from `bundle udpate` - RuboCop linting Signed-off-by: Peter Boling <peter.boling@gmail.com>
5044c73 to
6c79b9e
Compare
Contributor
Author
|
@sunny I thought I had already pushed those changes. I need more sleep I think! It should be good now. :) |
pboling
commented
Jun 8, 2022
pboling
commented
Jun 8, 2022
pboling
commented
Jun 8, 2022
pboling
commented
Jun 8, 2022
Contributor
Author
|
I will bump |
Owner
|
Wow, I hadn’t encountered these kind of version mixes with RuboCop before. Very happy to use |
⬇️ rubocop 1.30.1 => 1.12.1 - Last version to support Ruby 2.4 at runtime Signed-off-by: Peter Boling <peter.boling@gmail.com>
c72283d to
e5725cb
Compare
Contributor
Author
|
@sunny Done! |
Owner
|
Awesome! Great articles about the reasoning behind rubocop-lts, too. Thank you 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Peter Boling peter.boling@gmail.com