[pr] skip redundant root op check in compiled UPat matchers#16096
Closed
kimjune01 wants to merge 2 commits into
Closed
[pr] skip redundant root op check in compiled UPat matchers#16096kimjune01 wants to merge 2 commits into
kimjune01 wants to merge 2 commits into
Conversation
The compiled matcher already runs inside pdict[uop.op] dispatch. speeds cold schedule time: - softmax -15% - conv -14% - 4x conv -10% - transformer -9%
MEGA_MATCH=1 env var enables lazy compilation of merged match functions.
Each pattern runs through the existing _get_clause → pm_proc → pm_renderer
→ _final_render pipeline, then rendered lines are namespaced (a0 → a0_p{i})
and concatenated with shared cached locals (_s0, _s1, _s0op, _s1op).
Falls back to per-pattern dispatch on compilation failure.
Contributor
Changes |
Collaborator
|
You need to stop with AI PRs, you will be banned. We never trade complexity for speed |
kimjune01
added a commit
to kimjune01/speedygrad
that referenced
this pull request
May 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The compiled matcher already runs inside
pdict[uop.op]dispatch.speeds up cold schedule time: