Set the reset pins before connecting to the serial port

[floitsch]

No description provided.

[floitsch]

@CodeRabbit review

[coderabbitai]

✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

[coderabbitai]

Walkthrough

The serialOpen function signature in cmd/jag/commands/monitor.go was refactored to accept a baud rate as an integer parameter instead of a serial.Mode pointer. The function now constructs the serial.Mode internally with the provided baud rate and sets InitialStatusBits to maintain RTS/DTR assertion. Call sites were updated to pass baud rate directly.

Changes

Cohort / File(s)	Summary
Serial Port Configuration Refactoring cmd/jag/commands/monitor.go	Updated serialOpen function signature to accept baud rate as int parameter; modified serial.Open call to construct serial.Mode with BaudRate and InitialStatusBits for RTS/DTR handling on device open.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

🚥 Pre-merge checks | ✅ 1 | ❌ 2

❌ Failed checks (1 warning, 1 inconclusive)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.
Description check	❓ Inconclusive	No pull request description was provided by the author. The check cannot assess if the description is related to the changeset.	Provide a description explaining the purpose of setting reset pins before serial port connection and any motivation or issue this addresses.

✅ Passed checks (1 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly relates to the main change: setting reset pins (RTS/DTR via InitialStatusBits) before connecting to the serial port, which matches the code modifications in serialOpen.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch floitsch/set-reset-pins

---

No actionable comments were generated in the recent review. 🎉

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[floitsch]

@CodeRabbit review

[coderabbitai]

✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

[floitsch]

TBR.