Move theme toggler to a partial#39807
Merged
Merged
Conversation
e83a677 to
b21e4ec
Compare
52fa751 to
e329f60
Compare
XhmikosR
commented
Mar 20, 2024
| z-index: 1500; | ||
| } | ||
|
|
||
| .bd-mode-toggle .bi { |
Member
Author
There was a problem hiding this comment.
I plan to move all this inline CSS to an external file and inline it after processing it through Sass. That's for later, though.
julien-deramond
approved these changes
Mar 20, 2024
julien-deramond
left a comment
Member
There was a problem hiding this comment.
Just a minor modification in comment. The rest LGTM. It's a good idea to make this theme toggler a partial.
Co-authored-by: Julien Déramond <juderamond@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Motivation & Context
Type of changes
Checklist
npm run lint)Live previews
Related issues
TODO: