Skip to content

cp: Fixed posixly correct dangling symlink test#10247

Merged
ChrisDryden merged 1 commit into
uutils:mainfrom
max-amb:fix_cp_posixly_correct_test
Jan 17, 2026
Merged

cp: Fixed posixly correct dangling symlink test#10247
ChrisDryden merged 1 commit into
uutils:mainfrom
max-amb:fix_cp_posixly_correct_test

Conversation

@max-amb

@max-amb max-amb commented Jan 14, 2026

Copy link
Copy Markdown
Contributor

Currently the check for copying through a dangling symlink doesn't check if the file was actually created and if the contents of the file is correct. This doesn't match GNU behaviour in thru_dangling.sh.

Issue met while implementing #10011.

@github-actions

Copy link
Copy Markdown

GNU testsuite comparison:

Skip an intermittent issue tests/shuf/shuf-reservoir (fails in this run but passes in the 'main' branch)
Skip an intermittent issue tests/sort/sort-stale-thread-mem (fails in this run but passes in the 'main' branch)

Comment thread tests/by-util/test_cp.rs Outdated
…ts contents

cp: Added check of file contents in POSIXLY_CORRECT test

cp: Fixed windows test by including path

cp: Updated test
@max-amb max-amb force-pushed the fix_cp_posixly_correct_test branch from 06c5cce to a6f93d9 Compare January 15, 2026 00:22
@ChrisDryden ChrisDryden merged commit 2a044db into uutils:main Jan 17, 2026
132 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants