Skip to content

cp: fix recursive copy of readonly directories#10529

Merged
sylvestre merged 2 commits into
uutils:mainfrom
nikolalukovic:fix-7961
Feb 7, 2026
Merged

cp: fix recursive copy of readonly directories#10529
sylvestre merged 2 commits into
uutils:mainfrom
nikolalukovic:fix-7961

Conversation

@nikolalukovic

Copy link
Copy Markdown
Contributor

Attempt 2 to fix #7961

@github-actions

Copy link
Copy Markdown

GNU testsuite comparison:

Skipping an intermittent issue tests/tail/follow-name (passes in this run but fails in the 'main' branch)

@nikolalukovic

nikolalukovic commented Jan 28, 2026

Copy link
Copy Markdown
Contributor Author

Failing test is for a different util which I didn't touch.
Since I'm using the created value only in a single case when calling copy_attributes maybe it would be a good idea to turn the function parameter into an Option?

@github-actions

Copy link
Copy Markdown

GNU testsuite comparison:

Skipping an intermittent issue tests/shuf/shuf-reservoir (passes in this run but fails in the 'main' branch)
Skipping an intermittent issue tests/sort/sort-stale-thread-mem (passes in this run but fails in the 'main' branch)
Skipping an intermittent issue tests/tail/inotify-dir-recreate (passes in this run but fails in the 'main' branch)

@github-actions

Copy link
Copy Markdown

GNU testsuite comparison:

Skipping an intermittent issue tests/shuf/shuf-reservoir (passes in this run but fails in the 'main' branch)
Skipping an intermittent issue tests/sort/sort-stale-thread-mem (passes in this run but fails in the 'main' branch)

@nikolalukovic

Copy link
Copy Markdown
Contributor Author

@sylvestre can you please take a look? failing test is unrelated to these changes

@nikolalukovic nikolalukovic force-pushed the fix-7961 branch 2 times, most recently from fedf6a7 to be462bf Compare February 5, 2026 09:06
@github-actions

github-actions Bot commented Feb 6, 2026

Copy link
Copy Markdown

GNU testsuite comparison:

Skipping an intermittent issue tests/misc/usage_vs_getopt (passes in this run but fails in the 'main' branch)
Skipping an intermittent issue tests/shuf/shuf-reservoir (passes in this run but fails in the 'main' branch)
Skipping an intermittent issue tests/sort/sort-stale-thread-mem (passes in this run but fails in the 'main' branch)

@nikolalukovic

Copy link
Copy Markdown
Contributor Author

@sylvestre bump

@github-actions

github-actions Bot commented Feb 7, 2026

Copy link
Copy Markdown

GNU testsuite comparison:

Skip an intermittent issue tests/tail/follow-name (fails in this run but passes in the 'main' branch)
Skipping an intermittent issue tests/tty/tty-eof (passes in this run but fails in the 'main' branch)

@codspeed-hq

codspeed-hq Bot commented Feb 7, 2026

Copy link
Copy Markdown

Merging this PR will improve performance by 3.04%

⚡ 1 improved benchmark
✅ 283 untouched benchmarks
⏩ 38 skipped benchmarks1

Performance Changes

Mode Benchmark BASE HEAD Efficiency
Simulation cp_large_file[16] 381.3 µs 370 µs +3.04%

Comparing nikolalukovic:fix-7961 (2e5162f) with main (da7ad84)

Open in CodSpeed

Footnotes

  1. 38 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@sylvestre sylvestre merged commit 31c5102 into uutils:main Feb 7, 2026
153 of 155 checks passed
@sylvestre

Copy link
Copy Markdown
Contributor

thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

cp behaves differently on read-only directories

2 participants