Skip to content

cat: simplify splice & fix comment#11627

Merged
sylvestre merged 1 commit into
uutils:mainfrom
oech3:cat-simple
Apr 4, 2026
Merged

cat: simplify splice & fix comment#11627
sylvestre merged 1 commit into
uutils:mainfrom
oech3:cat-simple

Conversation

@oech3

@oech3 oech3 commented Apr 3, 2026

Copy link
Copy Markdown
Contributor
  • Remove const FIRST_PIPE_SIZE. It is not great if other utility already extent pipe size.
  • Fix comments (e.g. we don't avoid the overhead with small input yet...).
  • simplify match

@github-actions

github-actions Bot commented Apr 3, 2026

Copy link
Copy Markdown

GNU testsuite comparison:

GNU test failed: tests/timeout/timeout-group. tests/timeout/timeout-group is passing on 'main'. Maybe you have to rebase?
Skip an intermittent issue tests/date/resolution (fails in this run but passes in the 'main' branch)
Skipping an intermittent issue tests/tail/follow-name (passes in this run but fails in the 'main' branch)
Skip an intermittent issue tests/pr/bounded-memory (was skipped on 'main', now failing)

@oech3 oech3 marked this pull request as ready for review April 3, 2026 23:56
Comment thread src/uu/cat/src/splice.rs Outdated
@github-actions

github-actions Bot commented Apr 4, 2026

Copy link
Copy Markdown

GNU testsuite comparison:

Skipping an intermittent issue tests/date/date-locale-hour (passes in this run but fails in the 'main' branch)
Skipping an intermittent issue tests/tty/tty-eof (passes in this run but fails in the 'main' branch)
Note: The gnu test tests/dd/no-allocate is now being skipped but was previously passing.
Skip an intermittent issue tests/pr/bounded-memory (was skipped on 'main', now failing)

@sylvestre sylvestre merged commit 5ca5e01 into uutils:main Apr 4, 2026
167 checks passed
@oech3 oech3 deleted the cat-simple branch April 4, 2026 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants