URL: test host parsing of URLs with unknown schemes#4406
Merged
Conversation
Collaborator
|
Notifying @Sebmaster, @domenic, @frewsxcv, @mikewest, @rubys, @sideshowbarker, @smola, @tomalec, @xiaojunwu, and @zcorpan. (Learn how reviewing works.) |
47efa6b to
7d81096
Compare
annevk
added a commit
to whatwg/url
that referenced
this pull request
Jan 20, 2017
For URLs without a special scheme we cannot use the host parser directly due to compatibility issues. Instead we percent-encode the input. Tests: web-platform-tests/wpt#4406. Fixes #148.
19ee073 to
5406bb0
Compare
5406bb0 to
1d52991
Compare
annevk
added a commit
that referenced
this pull request
Jan 20, 2017
These used to be part of #4406.
Firefox (nightly channel)Testing web-platform-tests at revision 045b749 |
Chrome (unstable channel)Testing web-platform-tests at revision 290faf8 All results/url/url-constructor.html
/url/url-setters.html
/url/url-origin.html
/url/a-element-xhtml.xhtml
/url/a-element.html
/url/a-element-origin.html
/url/a-element-origin-xhtml.xhtml
|
domenic
approved these changes
Jan 24, 2017
annevk
added a commit
to whatwg/url
that referenced
this pull request
Jan 24, 2017
For URLs without a special scheme we cannot use the host parser directly due to compatibility issues. Instead we percent-encode the input. Also make sure that if "userinfo" or port is present, host is non-empty. Tests: web-platform-tests/wpt#4406. Fixes #148 and fixes #214.
annevk
added a commit
that referenced
this pull request
Jan 24, 2017
These used to be part of #4406.
annevk
added a commit
that referenced
this pull request
Jan 27, 2017
These used to be part of #4406.
annevk
added a commit
that referenced
this pull request
Jan 31, 2017
Some of these used to be part of #4406. See also whatwg/url#212.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
URL Standard change: whatwg/url#185.
This change is