Fix R_X86_64_GOTPC32_TLSDESC relaxations#1051
Merged
marxin merged 2 commits intoAug 15, 2025
Merged
Conversation
Properly detect the destination register and encode the information into the `mov` replacement instruction.
davidlattimore
approved these changes
Aug 15, 2025
mati865
approved these changes
Aug 15, 2025
mati865
left a comment
Member
There was a problem hiding this comment.
Thanks, I have checked mesa package on Arch Linux and it works fine.
It only tests LocalExec variant though.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Properly detect the destination register and encode the information into the
movreplacement instruction.Both variants are tested for
%raxin our test-suite (one via a Mold test). @mati865 can you please test the suggested fix?Fixes: #948