Look for dynamic linker in /bin/less in integ test#1159
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
More Illumos fun! This change checks
lessfor a dynamic linker as well. Formatting the array makes the change look larger than it is. Combined with #1158 we are now up to 27 passing integ tests on Illumos, up from just 9. As for whyless? Well, it's a pager that's pretty pervasively installed, so why not make a last-ditch effort there?It turns out that on Illumos, lots of coreutils are actually 32-bit binaries. I tracked this down to here. I printed the error returned by
object- something about invalid headers. Sure enough -lessis 64 bit andlsis 32 bit!