Replace all uses of bytemuck with zerocopy#1210
Merged
Merged
Conversation
Member
|
Thanks! One of the failures looks unrelated to your change and likely to be a flake. Hopefully once you run cargo fmt and reupload, the flake won't happen. Not sure how the flake is possible since we're supposed to have file locking to prevent that kind of thing |
99c6b9c to
af49d4f
Compare
davidlattimore
approved these changes
Oct 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1200. Unwraps have been used where bytemuck would panic on a size mismatch, or where the size is explicitly checked before performing the conversion.