Skip to content

perf: Run string merging and GC in parallel#1339

Merged
davidlattimore merged 1 commit into
mainfrom
push-sqpoyywkuprs
Nov 27, 2025
Merged

perf: Run string merging and GC in parallel#1339
davidlattimore merged 1 commit into
mainfrom
push-sqpoyywkuprs

Conversation

@davidlattimore

Copy link
Copy Markdown
Member

No description provided.

@davidlattimore

Copy link
Copy Markdown
Member Author

If I merge this, I'll split the first two commits off into separate PRs first.

@davidlattimore

Copy link
Copy Markdown
Member Author

Note, the other two commits are now separate PRs - #1343 and #1344. This PR without the other two doesn't help at all because with the two stages both using separate channels to control jobs, they end up blocking on their respective channels waiting for work. Merging the two stages to use the same channel ends up being pretty impractical.

@davidlattimore

Copy link
Copy Markdown
Member Author

I wanted to see if this PR was still a win after #1345. Seems like it still is, so I'll probably go ahead with it. The following are the changes I see in benchmarks for this change relative to #1345.

clang-debug: no change
clang-release: -1.1%
librustc-driver: -3.9%
wild: -3.1%

@davidlattimore davidlattimore marked this pull request as ready for review November 27, 2025 09:52
@davidlattimore davidlattimore merged commit b9c585a into main Nov 27, 2025
19 of 20 checks passed
@davidlattimore davidlattimore deleted the push-sqpoyywkuprs branch November 27, 2025 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant