fix: ifunc address equality for data section references#1441
Merged
Conversation
47f2626 to
3af8cd5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When an ifunc is referenced from a data section (e.g.,
void *ptr = my_ifunc), the pointer should have the same value as a direct function pointer reference to ensure address equality comparisons work correctly.For dynamic executables (both PIE and non-PIE), we now emit IRELATIVE relocations in
.rela.dynfor such references, allowing the dynamic linker to resolve them to the same target address.For static executables without a dynamic linker, the PLT address is used directly, which is handled automatically by
value_with_addend().