fix: delete the file instead of truncating it when updating busy executable#1466
Merged
davidlattimore merged 1 commit intoJan 18, 2026
Merged
Conversation
Contributor
Author
|
I don't think our tests infra can tests this scenario. We'd have to have to try to modify some binary while it was running. Maybe we can rely on mold test suite to cover this. |
Contributor
Author
|
I see no new passes on mold test suite. |
lapla-cogito
left a comment
Member
There was a problem hiding this comment.
I haven't reviewed the changes for this PR yet, but the issue related to the mold test suite appears to have existed for some time, specifically starting from this commit. Therefore, your changes are likely unrelated to this problem. (I'll take a look that when I have some available time.)
davidlattimore
approved these changes
Jan 18, 2026
davidlattimore
left a comment
Member
There was a problem hiding this comment.
Thanks for noticing and fixing this!
lapla-cogito
added a commit
that referenced
this pull request
Jan 21, 2026
context: #1466 (review) Some mold tests check for specific tool availability and skip them if the tool is missing (e.g., `command -v gdb >& /dev/null || skip`), which can lead to tests passing accidentally if additional packages aren't installed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When we try to update a running executable, and we fail because the file is busy, we retried with truncate which fails too. Instead, we have to remove the file, and create it again.
I encountered this bug sporadically when building stuff in the LLVM repo.