refactor: Change diagnostics::SymbolInfoPrinter to not capture lifetimes#1621
Merged
Conversation
This was necessary in order to remove the File=elf::File bound on layout::compute, otherwise we got various lifetime errors.
mati865
added a commit
to mati865/wild
that referenced
this pull request
Mar 9, 2026
It broke in wild-linker#1621, only printing the `update` was never called.
mati865
added a commit
that referenced
this pull request
Mar 9, 2026
It broke in #1621, only printing the `update` was never called.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was necessary in order to remove the File=elf::File bound on layout::compute, otherwise we got various lifetime errors.