feat: implement R_X86_64_CODE_* relocations with relaxations#1632
Merged
Conversation
Signed-off-by: vishruth-thimmaiah <vishruththimmaiah@gmail.com>
Member
Author
|
I've raised this PR as a draft as the latest stable release of object.rs doesnt include these relocs, which is why Ive used their hex values instead. |
davidlattimore
left a comment
Member
There was a problem hiding this comment.
Thanks for working on this. Can you add a test that uses these relaxations? It might need to be written in asm if you can't get the C compiler to produce them.
Signed-off-by: vishruth-thimmaiah <vishruththimmaiah@gmail.com>
Signed-off-by: vishruth-thimmaiah <vishruththimmaiah@gmail.com>
Signed-off-by: vishruth-thimmaiah <vishruththimmaiah@gmail.com>
Member
|
In Wild, we run mold tests via CI, and tests related to APX have started passing (see "Check tests that should fail still fail" in this). Could you remove these tests from |
Signed-off-by: vishruth-thimmaiah <vishruththimmaiah@gmail.com>
Signed-off-by: vishruth-thimmaiah <vishruththimmaiah@gmail.com>
Signed-off-by: vishruth-thimmaiah <vishruththimmaiah@gmail.com>
Signed-off-by: vishruth-thimmaiah <vishruththimmaiah@gmail.com>
502f5c6 to
4c9259b
Compare
davidlattimore
approved these changes
Mar 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #1299
This PR adds support for the
R_X86_64_CODE_*relocations, with relaxations wherever possible.