feat: evaluate expressions within PROVIDE with evaluate_expression#1925
Merged
davidlattimore merged 1 commit intoMay 13, 2026
Merged
Conversation
46cd439 to
cf59f9f
Compare
davidlattimore
left a comment
Member
There was a problem hiding this comment.
Sorry for the merge conflicts arising from my PR yesterday.
This PR adds support for the PROVIDE/PROVIDE_HIDDEN commands to parse and evaluate expressions using the evaluate_expression function. This PR also lets us evaluate complex expressions within --defsym arguements. Currently, SEGMENT_START isn't yet handled by evaluate_expression. Signed-off-by: vishruth-thimmaiah <vishruththimmaiah@gmail.com>
f6000d7 to
ed3ea80
Compare
davidlattimore
approved these changes
May 13, 2026
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for the
PROVIDE/PROVIDE_HIDDENcommands to parse and evaluate expressions using theevaluate_expressionfunction. This PR also lets us evaluate complex expressions within--defsymarguements.Currently,
SEGMENT_STARTisn't yet handled byevaluate_expression.