Output dynamic executable when the executable depends on shared objects#879
Merged
Merged
Conversation
| command | ||
| .arg("-dynamic-linker") | ||
| .arg(dynamic_linker_path(cross_arch)); | ||
| // TODO: `export-dynamic` test reproduces the problem only when using neither `-static` nor `-dynamic-linker` |
Member
There was a problem hiding this comment.
I guess one option here would be to replace is_static with an enum. e.g. //#Mode:static, //#Mode:dynamic, //#Mode:unspecified. The current default would be static, but I'm also open to changing that default to unspecified if we wanted - although we'd need to update a bunch of tests to explicitly specify //#Mode:static.
e47b988 to
b7029e8
Compare
04648e3 to
9e7dc2e
Compare
9e7dc2e to
d722874
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #836