Version script glob support#943
Conversation
7297ba1 to
33a4597
Compare
davidlattimore
left a comment
There was a problem hiding this comment.
Thanks! Definitely good to have support for more patterns. The utf-8 string thing does make me a bit uneasy, but I guess we can go with it and potentially change it to something byte-based later.
Out of curiosity, what kinds of patterns have you encountered that weren't something*? Is it just patterns that have * somewhere in the middle, or have you found use of ? or character sets?
One example could be |
33a4597 to
e1ac194
Compare
Yep, my expectation is the glob patterns are not so common, and if so, then the total number of symbols is reasonably small. |
|
Well, in the context of #952, I believe, the symbol identifiers should be valid UTF-8 strings :) |
Based on the discussion with David, I tested the bevy with dynamic linking (500K symbols in a version script file), and I decided to keep the exact match implementation. The only change is that
glob::Patternis used for a general glob pattern; having that, the link time is equal forbevy. For a reasonably sized shared library that uses a couple of general globs, the speed should be good!Plus the PR support if a space(s) is present after a symbol name.