You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Thank you, @WilliamK112 — and congrats on the project's first external contribution! 🎉
This is exactly the kind of PR maintainers hope for. It follows the codebase conventions precisely (top-level source: SourceRef alongside the Traced[...] field, dispatch placement next to the other one-line globals, _col() for provenance, no garbage facts), handles bothntp-service unicast-server and the older ntp unicast-server form, captures the optional vpn-instance, and the tests cover the syntax variants, vpn-instance, SourceRef line/col, and serialization.
Verified locally and in CI: 153 tests pass (3.9 + 3.12), ruff clean. Merging now — thanks for jumping on #39.
If you'd like another in the same vein, #37 (parse snmp-agent community) and #41 (parse info-center loghost) are open and structured the same way. 🙌
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
NtpServerIR model plusVrpConfig.ntp_serversntp-service unicast-serverand olderntp unicast-serverforms with SourceRef-backed address and optionalvpn-instancetests/test_ntp.pyfor syntax variants, vpn-instance, SourceRef, and serializationFixes #39
Validation
PYTHONPATH=src python -m unittest discover -s tests -p test_ntp.py -v✅ (6 passed)PYTHONPATH=src python -m unittest discover -s tests -v✅ (153 passed)uvx ruff check src tests✅git diff --check✅