Repository navigation
Conversation
RiinaVi
reviewed
Feb 7, 2023
| ````warn header="Same global regexp tested repeatedly on different sources may fail" | ||
| If we apply the same global regexp to different inputs, it may lead to wrong result, because `regexp.test` call advances `regexp.lastIndex` property, so the search in another string may start from non-zero position. | ||
| ````warn header="ΠΠ΄ΠΈΠ½ Ρ ΡΠΎΠΉ ΡΠ°ΠΌΠΈΠΉ Π³Π»ΠΎΠ±Π°Π»ΡΠ½ΠΈΠΉ ΡΠ΅Π³ΡΠ»ΡΡΠ½ΠΈΠΉ Π²ΠΈΡΠ°Π·, ΠΏΡΠΎΡΠ΅ΡΡΠΎΠ²Π°Π½ΠΈΠΉ Π±Π°Π³Π°ΡΠΎ ΡΠ°Π·ΡΠ² Π½Π° ΡΡΠ·Π½ΠΈΡ Π΄Π°Π½ΠΈΡ , ΠΌΠΎΠΆΠ΅ ΠΏΠΎΠΌΠΈΠ»ΡΡΠΈΡΡ" | ||
| Π―ΠΊΡΠΎ ΠΌΠΈ Π·Π°ΡΡΠΎΡΡΡΠΌΠΎ ΠΎΠ΄ΠΈΠ½ Ρ ΡΠΎΠΉ ΡΠ°ΠΌΠΈΠΉ Π³Π»ΠΎΠ±Π°Π»ΡΠ½ΠΈΠΉ ΡΠ΅Π³ΡΠ»ΡΡΠ½ΠΈΠΉ Π²ΠΈΡΠ°Π· Π΄ΠΎ ΡΡΠ·Π½ΠΈΡ Π²Ρ ΡΠ΄Π½ΠΈΡ Π΄Π°Π½ΠΈΡ , ΠΌΠΎΠΆΠ΅ΠΌΠΎ ΠΎΡΡΠΈΠΌΠ°ΡΠΈ Π½Π΅ΠΏΡΠ°Π²ΠΈΠ»ΡΠ½Ρ ΡΠ΅Π·ΡΠ»ΡΡΠ°ΡΠΈ, Π±ΠΎ Π²ΠΈΠΊΠ»ΠΈΠΊ `regexp.test` ΠΏΠΎΡΡΠ²Π°Ρ Π²Π»Π°ΡΡΠΈΠ²ΡΡΡΡ `regexp.lastIndex`, ΡΠΎΠΆ ΠΏΠΎΡΡΠΊ Π² ΡΠ½ΡΠΎΠΌΡ ΡΡΠ΄ΠΊΡ ΠΌΠΎΠΆΠ΅ ΠΏΠΎΡΠ°ΡΠΈΡΡ Π· ΠΏΠΎΠ·ΠΈΡΡΡ, Π²ΡΠ΄ΠΌΡΠ½Π½ΠΎΡ Π²ΡΠ΄ Π½ΡΠ»Ρ. |
Contributor
There was a problem hiding this comment.
"Π²ΡΠ΄ΠΌΡΠ½Π½ΠΎΡ"? ΠΏΠΎΠ·ΠΈΡΡΡ ΡΠΊΠΎΡ? - "Π²ΡΠ΄ΠΌΡΠ½Π½ΠΎΡ"
tarasyyyk
approved these changes
May 24, 2023
Contributor
|
Thank you π I updated the Progress Issue #1 π π π |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.