Repository navigation
Conversation
SamGreenberg
marked this pull request as draft
January 26, 2023 20:46
dolgachio
self-requested a review
June 5, 2023 10:37
Collaborator
|
@SamGreenberg ΠΡΠ΄ΠΊΠ°ΠΆΡΡΡ Π±ΡΠ΄Ρ Π»Π°ΡΠΊΠ°, ΡΠΈ Π°ΠΊΡΡΠ°Π»ΡΠ½ΠΈΠΉ ΡΡΠ°ΡΡΡ |
SamGreenberg
marked this pull request as ready for review
August 14, 2023 14:38
Contributor
Author
|
@stas-dolgachov draft Π±ΡΠ»ΡΡΠ΅ Π½Π΅ Π°ΠΊΡΡΠ°Π»ΡΠ½ΠΈΠΉ |
dolgachio
approved these changes
Aug 22, 2023
dolgachio
left a comment
Collaborator
There was a problem hiding this comment.
ΠΡΠΊΡΡ, Π·Π° ΡΡΠ΄ΠΎΠ²ΠΈΠΉ ΠΏΠ΅ΡΠ΅ΠΊΠ»Π°Π΄! Π― Π·Π°ΡΠ°Π· Π·ΡΠΎΠ±Π»Ρ ΠΊΡΠ»ΡΠΊΠ° Π½Π΅Π²Π΅Π»ΠΈΡΠΊΠΈΡ ΠΏΡΠ°Π²ΠΎΠΊ Ρ ΠΏΡΠΈΠΉΠΌΡ ΠΉΠΎΠ³ΠΎ
| : ΠΠΊΠ»ΡΡΠ°ΡΡΡΡΡ Π·Π½Π°ΠΊΠΎΠΌ ΠΏΠΈΡΠ°Π½Π½Ρ `pattern:?` ΠΏΡΡΠ»Ρ ΠΊΠ²Π°Π½ΡΠΈΡΡΠΊΠ°ΡΠΎΡΡ. Π ΡΡΡΠΉ Π½Π°ΠΌΠ°Π³Π°ΡΡΡΡΡ Π·Π½Π°ΠΉΡΠΈ Π·Π±ΡΠ³ ΡΠ΅ΡΡΠΈ ΠΏΠ°ΡΠ΅ΡΠ½Ρ ΠΏΠ΅ΡΠ΅Π΄ ΠΊΠΎΠΆΠ½ΠΈΠΌ ΠΏΠΎΠ²ΡΠΎΡΠ΅Π½Π½ΡΠΌ ΠΊΠ²Π°Π½ΡΠΈΡΡΠΊΠΎΠ²Π°Π½ΠΎΠ³ΠΎ ΡΠΈΠΌΠ²ΠΎΠ»Ρ. | ||
|
|
||
| As we've seen, the lazy mode is not a "panacea" from the greedy search. An alternative is a "fine-tuned" greedy search, with exclusions, as in the pattern `pattern:"[^"]+"`. | ||
| Π―ΠΊ Π±Π°ΡΠΈΠΌΠΎ, Π»ΡΠ½ΠΈΠ²ΠΈΠΉ ΡΠ΅ΠΆΠΈΠΌ Π½Π΅ Ρ "ΠΏΠ°Π½Π°ΡΠ΅ΡΡ" Π²ΡΠ΄ ΠΆΠ°Π΄ΡΠ±Π½ΠΎΠ³ΠΎ ΠΏΠΎΡΡΠΊΡ. Π―ΠΊ Π°Π»ΡΡΠ΅ΡΠ½Π°ΡΠΈΠ²Ρ ΡΠΎΠ·Π³Π»ΡΠ΄Π°ΡΡΡ "Π΄ΠΎΠ±ΡΠ΅ Π½Π°Π»Π°ΡΡΠΎΠ²Π°Π½ΠΈΠΉ" ΠΆΠ°Π΄ΡΠ±Π½ΠΈΠΉ ΠΏΠΎΡΡΠΊ, Π· Π²ΠΈΠΊΠ»ΡΡΠ΅Π½Π½ΡΠΌ, ΡΠΊ Π² ΠΏΠ°ΡΠ΅ΡΠ½Ρ `pattern:"[^"]+"`. |
Collaborator
There was a problem hiding this comment.
Suggested change
| Π―ΠΊ Π±Π°ΡΠΈΠΌΠΎ, Π»ΡΠ½ΠΈΠ²ΠΈΠΉ ΡΠ΅ΠΆΠΈΠΌ Π½Π΅ Ρ "ΠΏΠ°Π½Π°ΡΠ΅ΡΡ" Π²ΡΠ΄ ΠΆΠ°Π΄ΡΠ±Π½ΠΎΠ³ΠΎ ΠΏΠΎΡΡΠΊΡ. Π―ΠΊ Π°Π»ΡΡΠ΅ΡΠ½Π°ΡΠΈΠ²Ρ ΡΠΎΠ·Π³Π»ΡΠ΄Π°ΡΡΡ "Π΄ΠΎΠ±ΡΠ΅ Π½Π°Π»Π°ΡΡΠΎΠ²Π°Π½ΠΈΠΉ" ΠΆΠ°Π΄ΡΠ±Π½ΠΈΠΉ ΠΏΠΎΡΡΠΊ, Π· Π²ΠΈΠΊΠ»ΡΡΠ΅Π½Π½ΡΠΌ, ΡΠΊ Π² ΠΏΠ°ΡΠ΅ΡΠ½Ρ `pattern:"[^"]+"`. | |
| Π―ΠΊ Π±Π°ΡΠΈΠΌΠΎ, Π»ΡΠ½ΠΈΠ²ΠΈΠΉ ΡΠ΅ΠΆΠΈΠΌ Π½Π΅ Ρ "ΠΏΠ°Π½Π°ΡΠ΅ΡΡ" Π²ΡΠ΄ ΠΆΠ°Π΄ΡΠ±Π½ΠΎΠ³ΠΎ ΠΏΠΎΡΡΠΊΡ. Π―ΠΊ Π°Π»ΡΡΠ΅ΡΠ½Π°ΡΠΈΠ²Ρ ΡΠΎΠ·Π³Π»ΡΠ΄Π°ΡΡΡ "Π΄ΠΎΠ±ΡΠ΅ Π½Π°Π»Π°ΡΡΠΎΠ²Π°Π½ΠΈΠΉ" ΠΆΠ°Π΄ΡΠ±Π½ΠΈΠΉ ΠΏΠΎΡΡΠΊ, Π· Π²ΠΈΠΊΠ»ΡΡΠ΅Π½Π½ΡΠΌ, ΡΠΊ Π² ΡΠ°Π±Π»ΠΎΠ½Ρ `pattern:"[^"]+"`. |
| 2. Then it looks for `pattern:.*?`: takes one character (lazily!), check if there's a match for `pattern:" class="doc">` (none). | ||
| 3. Then takes another character into `pattern:.*?`, and so on... until it finally reaches `match:" class="doc">`. | ||
| 1. Π‘ΠΏΠΎΡΠ°ΡΠΊΡ, ΡΠ΅Π³ΡΠ»ΡΡΠ½ΠΈΠΉ Π²ΠΈΡΠ°Π· Π·Π½Π°Ρ ΠΎΠ΄ΠΈΡΡ ΠΏΠΎΡΠ°ΡΠΎΠΊ ΠΏΠΎΡΠΈΠ»Π°Π½Π½Ρ `match:<a href="`. | ||
| 2. ΠΠ°Π»Ρ, Π²ΡΠ½ ΡΡΠΊΠ°Ρ `pattern:.*?`: Π±Π΅ΡΠ΅ ΠΎΠ΄ΠΈΠ½ ΡΠΈΠΌΠ²ΠΎΠ» (Π»ΡΠ½ΠΈΠ²ΠΎ!), ΠΏΠ΅ΡΠ΅Π²ΡΡΡΡ Π½Π°ΡΠ²Π½ΡΡΡΡ Π·Π±ΡΠ³Ρ Π΄Π»Ρ `pattern:" class="doc">` (Π½Π΅ΠΌΠ°). |
Collaborator
There was a problem hiding this comment.
Suggested change
| 2. ΠΠ°Π»Ρ, Π²ΡΠ½ ΡΡΠΊΠ°Ρ `pattern:.*?`: Π±Π΅ΡΠ΅ ΠΎΠ΄ΠΈΠ½ ΡΠΈΠΌΠ²ΠΎΠ» (Π»ΡΠ½ΠΈΠ²ΠΎ!), ΠΏΠ΅ΡΠ΅Π²ΡΡΡΡ Π½Π°ΡΠ²Π½ΡΡΡΡ Π·Π±ΡΠ³Ρ Π΄Π»Ρ `pattern:" class="doc">` (Π½Π΅ΠΌΠ°). | |
| 2. ΠΠ°Π»Ρ, Π²ΡΠ½ ΡΡΠΊΠ°Ρ `pattern:.*?`: Π±Π΅ΡΠ΅ ΠΎΠ΄ΠΈΠ½ ΡΠΈΠΌΠ²ΠΎΠ» (Π»ΡΠ½ΠΈΠ²ΠΎ!), ΠΏΠ΅ΡΠ΅Π²ΡΡΡΡ Π½Π°ΡΠ²Π½ΡΡΡΡ Π·Π±ΡΠ³Ρ Π΄Π»Ρ `pattern:" class="doc">` (Π½Π΅ΠΌΠ°Ρ). |
| Lazy | ||
| : Enabled by the question mark `pattern:?` after the quantifier. The regexp engine tries to match the rest of the pattern before each repetition of the quantified character. | ||
| ΠΡΠ½ΠΈΠ²ΠΈΠΉ | ||
| : ΠΠΊΠ»ΡΡΠ°ΡΡΡΡΡ Π·Π½Π°ΠΊΠΎΠΌ ΠΏΠΈΡΠ°Π½Π½Ρ `pattern:?` ΠΏΡΡΠ»Ρ ΠΊΠ²Π°Π½ΡΠΈΡΡΠΊΠ°ΡΠΎΡΡ. Π ΡΡΡΠΉ Π½Π°ΠΌΠ°Π³Π°ΡΡΡΡΡ Π·Π½Π°ΠΉΡΠΈ Π·Π±ΡΠ³ ΡΠ΅ΡΡΠΈ ΠΏΠ°ΡΠ΅ΡΠ½Ρ ΠΏΠ΅ΡΠ΅Π΄ ΠΊΠΎΠΆΠ½ΠΈΠΌ ΠΏΠΎΠ²ΡΠΎΡΠ΅Π½Π½ΡΠΌ ΠΊΠ²Π°Π½ΡΠΈΡΡΠΊΠΎΠ²Π°Π½ΠΎΠ³ΠΎ ΡΠΈΠΌΠ²ΠΎΠ»Ρ. |
Collaborator
There was a problem hiding this comment.
Suggested change
| : ΠΠΊΠ»ΡΡΠ°ΡΡΡΡΡ Π·Π½Π°ΠΊΠΎΠΌ ΠΏΠΈΡΠ°Π½Π½Ρ `pattern:?` ΠΏΡΡΠ»Ρ ΠΊΠ²Π°Π½ΡΠΈΡΡΠΊΠ°ΡΠΎΡΡ. Π ΡΡΡΠΉ Π½Π°ΠΌΠ°Π³Π°ΡΡΡΡΡ Π·Π½Π°ΠΉΡΠΈ Π·Π±ΡΠ³ ΡΠ΅ΡΡΠΈ ΠΏΠ°ΡΠ΅ΡΠ½Ρ ΠΏΠ΅ΡΠ΅Π΄ ΠΊΠΎΠΆΠ½ΠΈΠΌ ΠΏΠΎΠ²ΡΠΎΡΠ΅Π½Π½ΡΠΌ ΠΊΠ²Π°Π½ΡΠΈΡΡΠΊΠΎΠ²Π°Π½ΠΎΠ³ΠΎ ΡΠΈΠΌΠ²ΠΎΠ»Ρ. | |
| : ΠΠΊΠ»ΡΡΠ°ΡΡΡΡΡ Π·Π½Π°ΠΊΠΎΠΌ ΠΏΠΈΡΠ°Π½Π½Ρ `pattern:?` ΠΏΡΡΠ»Ρ ΠΊΠ²Π°Π½ΡΠΈΡΡΠΊΠ°ΡΠΎΡΡ. Π ΡΡΡΠΉ Π½Π°ΠΌΠ°Π³Π°ΡΡΡΡΡ Π·Π½Π°ΠΉΡΠΈ Π·Π±ΡΠ³ ΡΠ΅ΡΡΠΈ ΡΠ°Π±Π»ΠΎΠ½Ρ ΠΏΠ΅ΡΠ΅Π΄ ΠΊΠΎΠΆΠ½ΠΈΠΌ ΠΏΠΎΠ²ΡΠΎΡΠ΅Π½Π½ΡΠΌ ΠΊΠ²Π°Π½ΡΠΈΡΡΠΊΠΎΠ²Π°Π½ΠΎΠ³ΠΎ ΡΠΈΠΌΠ²ΠΎΠ»Ρ. |
Contributor
|
Thank you π I updated the Progress Issue #1 π π π |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.