Code/compile fixes#184
Conversation
|
Love the PR thank you!!! I'm curious to hear @hschoenburg 's thoughts about the re-ordering of the tutorial though. I think he had that order in mind to show what a completely basic chain could do before showing what extra functionality could add. Might make sense to switch it up, but if so we should keep an eye out for continuity errors like here: |
|
Ok, I added another PR without the restructuring |
|
Sorry, I meant that I removed the restructuring from this PR and added another PR that includes the restructuring |
|
|
||
| install: go.sum | ||
| go install $(BUILD_FLAGS) ./cmd/hcd | ||
| go install $(BUILD_FLAGS) ./cmd/hccli |
There was a problem hiding this comment.
I do believe this should stay here
There was a problem hiding this comment.
The order of the tutorial makes it such that hccli doesn't exist at the point the user make installs this make file - that's why I originally reordered the files, which is now in #185
Changed:
make.mdfile to near the end because it requires that the cli is builtx/greeter/client/cli/query.goinclient.md