Skip to content

Add missing inline keyword to always_inline functions#1510

Merged
chfast merged 1 commit into
masterfrom
inline
Apr 15, 2026
Merged

Add missing inline keyword to always_inline functions#1510
chfast merged 1 commit into
masterfrom
inline

Conversation

@chfast

@chfast chfast commented Apr 15, 2026

Copy link
Copy Markdown
Member

GCC requires both [[gnu::always_inline]] and the inline keyword, otherwise it warns "function might not be inlinable". The functions were already being inlined.

This was silenced by the -Wno-attributes warning, now tuned to ignore only attributes with known vendor prefixes.

@codecov

codecov Bot commented Apr 15, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.74%. Comparing base (06adc75) to head (1952542).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1510   +/-   ##
=======================================
  Coverage   96.74%   96.74%           
=======================================
  Files         156      156           
  Lines       14163    14163           
  Branches     3336     3336           
=======================================
  Hits        13702    13702           
  Misses        317      317           
  Partials      144      144           
Flag Coverage Δ
eest-develop 92.07% <ø> (ø)
eest-develop-gmp 27.57% <ø> (ø)
eest-legacy 15.04% <ø> (ø)
eest-libsecp256k1 29.27% <ø> (ø)
eest-stable 91.98% <ø> (ø)
evmone-unittests 91.52% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
core 96.01% <ø> (ø)
tooling 84.60% <ø> (ø)
tests 99.79% <ø> (ø)
Files with missing lines Coverage Δ
lib/evmone_precompiles/blake2b.cpp 100.00% <ø> (ø)
lib/evmone_precompiles/modexp.cpp 99.63% <ø> (ø)
lib/evmone_precompiles/sha256.cpp 40.07% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

GCC requires both [[gnu::always_inline]] and the inline keyword,
otherwise it warns "function might not be inlinable". The functions
were already being inlined.

This was silenced by the -Wno-attributes warning, now tuned to ignore
only attributes with known vendor prefixes.
@chfast chfast merged commit b487188 into master Apr 15, 2026
23 checks passed
@chfast chfast deleted the inline branch April 15, 2026 09:05
somnergy pushed a commit to erigontech/zvm1 that referenced this pull request May 23, 2026
Merges upstream evmone (ipsilon/evmone) master through commit ff942e2
into zevmone main. Brings in the post-EVMC-vendoring upstream commits:

  - evmone 0.20.0 and 0.21.0 releases
  - EVMC vendoring follow-ups: remove loader library and old evmc tool
    (ipsilon#1504), drop external EVMC support in evmone-bench (ipsilon#1503), add
    standalone evmone CLI tool (ipsilon#1502), bump CMake to 3.22 (ipsilon#1501),
    remove redundant build configuration (ipsilon#1505)
  - Add Amsterdam EVM revision (ipsilon#1508)
  - Implement DUPN/SWAPN/EXCHANGE EIP-8024 (ipsilon#1429)
  - Extract SWAP instruction helper (ipsilon#1509)
  - Restrict conjugate() to degree-2 extension fields (ipsilon#1485)
  - Add missing inline keyword to always_inline functions (ipsilon#1510)
  - CI updates: run EEST develop (ipsilon#1507), drop legacy state tests
    (ipsilon#1512), set LLVM_PROFILE_FILE per run (ipsilon#1513)

Conflict resolution (matches the existing merge-upstream branch):
  - Adopt upstream's parameterized run_execution_spec_tests command and
    upstream-style call sites (release/fixtures_suffix/filter); drop the
    duplicate non-parameterized definition merged in from HEAD
  - circle.yml gcc-min job: rename CMAKE_OPTIONS=-DEVMC_TOOLS=OFF to
    -DEVMONE_TOOLS=OFF (option moved to evmone scope after vendoring)
  - .bumpversion.cfg, CHANGELOG.md, CMakeLists.txt: take upstream
  - evmc/* (add/add): take upstream's vendored EVMC tree
  - lib/evmone_precompiles/ecc.hpp: keep test_bit() helper (not yet in
    upstream intx)
  - lib/evmone_precompiles/modexp.cpp: keep SP1 modexp_sp1() function
    and its dispatch alongside upstream's bump-allocator refactor
  - test/integration/CMakeLists.txt: take upstream
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant