Skip to content

ci: Don't run legacy state tests#1512

Merged
chfast merged 1 commit into
masterfrom
ci/no_legacy_state_tests
Apr 24, 2026
Merged

ci: Don't run legacy state tests#1512
chfast merged 1 commit into
masterfrom
ci/no_legacy_state_tests

Conversation

@chfast

@chfast chfast commented Apr 24, 2026

Copy link
Copy Markdown
Member

Don't run legacy state tests because we later want to use some new JSON test features available only in EEST files.

The lost coverage is minimal and also covered by internal unit tests.

@codecov

codecov Bot commented Apr 24, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.78%. Comparing base (14fbedc) to head (e5f493f).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1512      +/-   ##
==========================================
- Coverage   96.82%   96.78%   -0.05%     
==========================================
  Files         156      156              
  Lines       14163    14163              
  Branches     3336     3336              
==========================================
- Hits        13714    13708       -6     
- Misses        312      314       +2     
- Partials      137      141       +4     
Flag Coverage Δ
eest-develop 92.07% <ø> (ø)
eest-develop-gmp 27.57% <ø> (ø)
eest-legacy 17.69% <ø> (-13.16%) ⬇️
eest-libsecp256k1 29.27% <ø> (ø)
eest-stable 91.98% <ø> (ø)
evmone-unittests 91.52% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
core 96.03% <ø> (ø)
tooling 84.90% <ø> (-0.37%) ⬇️
tests 99.79% <ø> (ø)
see 3 files with indirect coverage changes
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Don't run legacy state tests because we later want to use some new
JSON test features available only in EEST files.

The lost coverage is minimal and also covered by internal unit tests.
@chfast chfast force-pushed the ci/no_legacy_state_tests branch from b9dd8d5 to e5f493f Compare April 24, 2026 19:50
@chfast chfast merged commit ff942e2 into master Apr 24, 2026
22 of 23 checks passed
@chfast chfast deleted the ci/no_legacy_state_tests branch April 24, 2026 21:14
somnergy pushed a commit to erigontech/zvm1 that referenced this pull request May 23, 2026
Merges upstream evmone (ipsilon/evmone) master through commit ff942e2
into zevmone main. Brings in the post-EVMC-vendoring upstream commits:

  - evmone 0.20.0 and 0.21.0 releases
  - EVMC vendoring follow-ups: remove loader library and old evmc tool
    (ipsilon#1504), drop external EVMC support in evmone-bench (ipsilon#1503), add
    standalone evmone CLI tool (ipsilon#1502), bump CMake to 3.22 (ipsilon#1501),
    remove redundant build configuration (ipsilon#1505)
  - Add Amsterdam EVM revision (ipsilon#1508)
  - Implement DUPN/SWAPN/EXCHANGE EIP-8024 (ipsilon#1429)
  - Extract SWAP instruction helper (ipsilon#1509)
  - Restrict conjugate() to degree-2 extension fields (ipsilon#1485)
  - Add missing inline keyword to always_inline functions (ipsilon#1510)
  - CI updates: run EEST develop (ipsilon#1507), drop legacy state tests
    (ipsilon#1512), set LLVM_PROFILE_FILE per run (ipsilon#1513)

Conflict resolution (matches the existing merge-upstream branch):
  - Adopt upstream's parameterized run_execution_spec_tests command and
    upstream-style call sites (release/fixtures_suffix/filter); drop the
    duplicate non-parameterized definition merged in from HEAD
  - circle.yml gcc-min job: rename CMAKE_OPTIONS=-DEVMC_TOOLS=OFF to
    -DEVMONE_TOOLS=OFF (option moved to evmone scope after vendoring)
  - .bumpversion.cfg, CHANGELOG.md, CMakeLists.txt: take upstream
  - evmc/* (add/add): take upstream's vendored EVMC tree
  - lib/evmone_precompiles/ecc.hpp: keep test_bit() helper (not yet in
    upstream intx)
  - lib/evmone_precompiles/modexp.cpp: keep SP1 modexp_sp1() function
    and its dispatch alongside upstream's bump-allocator refactor
  - test/integration/CMakeLists.txt: take upstream
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant