Skip to content

Fix macOS fat32 platform tag typo? -> fat3.#1199

Merged
brettcannon merged 2 commits into
pypa:mainfrom
jsirois:fat32/fat3
May 28, 2026
Merged

Fix macOS fat32 platform tag typo? -> fat3.#1199
brettcannon merged 2 commits into
pypa:mainfrom
jsirois:fat32/fat3

Conversation

@jsirois

@jsirois jsirois commented May 27, 2026

Copy link
Copy Markdown
Contributor

This was introduced in #156 and appears to originate in CPython via
distutils via python/cpython@bea37aee6b2d.
Afaict this was likely a Windows-user Freudian file-system slip but
never was an issue since the PR was in 2019 which was well past the
~2009 3-way fat binary era and wheels only came along in 2013, also
well past the era; so there were never any wheels with fat3 (or
fat32!) tags.

C.F.:

This was introduced in pypa#156 and appears to originate in CPython via
distutils via python/cpython@bea37aee6b2d.
Afaict this was likely a Windows-user Freudian file-system slip but
never was an issue since the PR was in 2019 which was well past the
~2009 3-way fat binary era.

C.F.:
+ Assume packaging was right and this was a spec bug 1st:
  pypa/packaging.python.org#2062 (review)
+ Original CPython Issue introducing fat3:
  https://bugs.python.org/issue6245
@jsirois

jsirois commented May 27, 2026

Copy link
Copy Markdown
Contributor Author

For context: I was re-implementing tag enumeration for Pex in Rust and had noticed this discrepancy between packaging/tags.py (the only real "spec" for what tags an interpreter should support and in which order) and the official spec and wanted to make sure I was doing things right.

@brettcannon brettcannon merged commit 45d1530 into pypa:main May 28, 2026
58 checks passed
@brettcannon

Copy link
Copy Markdown
Member

Thanks!

@jsirois jsirois deleted the fat32/fat3 branch May 29, 2026 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants