Introduce packaging.tags#156
Conversation
First, add pytest as a dev requirement, else it won't run as its own command. Second, drop the dot. Third, use -m to help control which interpreter is used.
njsmith
left a comment
There was a problem hiding this comment.
Awesome to see this moving forward :-). A few comments below.
Are you planning to switch pip over to using this?
|
Just to set expectations, I'm probably not going to get to looking at this until Christmas-ish. It's significant new functionality and it'll take me a bit to ramp up on it. |
|
@dstufft Thanks for the update and no problem from my end. Have a happy holidays! |
|
OK, the PR now passes CI! Over to you, @dstufft 😁 |
|
Anything I can do to help move this forward, @dstufft ? Do you want me to break this up somewhat? I could do platform-independent stuff and then do separate PRs for Windows, Linux, and macOS if that would help get this reviewed. |
|
No, I just forgot about it. I'll take a look at it later this week. Thanks for the reminder! |
|
I now have a use for this at work, so I'm prodding again about what I can do to help get this reviewed. |
dstufft
left a comment
There was a problem hiding this comment.
Made some comments. I feel really bad about how long I left this sit, so feel free to push back on things if reworking them would require a bunch of additional effort. Overall I think the structure here is fairly reasonable.
|
@dstufft PTAL |
dstufft
left a comment
There was a problem hiding this comment.
Awesome. This looks great ✨ Sorry that it took so long to get reviewed.
|
Thanks for landing this! And no problem about the time, just glad it worked out in the end. |
This was introduced in pypa#156 and appears to originate in CPython via distutils via python/cpython@bea37aee6b2d. Afaict this was likely a Windows-user Freudian file-system slip but never was an issue since the PR was in 2019 which was well past the ~2009 3-way fat binary era. C.F.: + Assume packaging was right and this was a spec bug 1st: pypa/packaging.python.org#2062 (review) + Original CPython Issue introducing fat3: https://bugs.python.org/issue6245
This was introduced in #156 and appears to originate in CPython via distutils via python/cpython@bea37aee6b2d. Afaict this was likely a Windows-user Freudian file-system slip but never was an issue since the PR was in 2019 which was well past the ~2009 3-way fat binary era. C.F.: + Assume packaging was right and this was a spec bug 1st: pypa/packaging.python.org#2062 (review) + Original CPython Issue introducing fat3: https://bugs.python.org/issue6245
Add support for PEP 425: Compatibility Tags for Built Distributions.
Closes #83