Promote char::is_case_ignorable from perma-unstable to unstable#154849
Merged
Conversation
3 tasks
Member
|
@bors r+ rollup |
Contributor
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Apr 5, 2026
…Mark-Simulacrum Promote `char::is_case_ignorable` from perma-unstable to unstable (Take two of rust-lang#154658, which was closed when GitHub Codespaces somehow managed to squash the entire commit history of rust-lang/rust into one commit) This function is currently used in the implementation of `str::to_lowercase()`. There is no reason to restrict it to the stdlib, though. Reimplementations of string casing for types other than `str` -> `String` shouldn't need to waste space with a duplicate copy of this table. @rustbot label A-unicode T-libs-api r? @Mark-Simulacrum
rust-bors Bot
pushed a commit
that referenced
this pull request
Apr 5, 2026
…uwer Rollup of 8 pull requests Successful merges: - #153440 (Various LTO cleanups) - #154561 (Suggest similar keyword when visibility is not followed by an item) - #154657 (Fix pattern assignment suggestions for uninitialized bindings) - #154717 (Fix ICE in unsafe binder discriminant helpers) - #154722 (fix(lints): Improve `ill_formed_attribute_input` with better help message) - #154808 (Post-attribute ports cleanup pt. 1) - #154849 (Promote `char::is_case_ignorable` from perma-unstable to unstable) - #154850 (ast_validation: scalable vectors okay for rustdoc)
rust-bors Bot
pushed a commit
that referenced
this pull request
Apr 5, 2026
…uwer Rollup of 8 pull requests Successful merges: - #153440 (Various LTO cleanups) - #154561 (Suggest similar keyword when visibility is not followed by an item) - #154657 (Fix pattern assignment suggestions for uninitialized bindings) - #154717 (Fix ICE in unsafe binder discriminant helpers) - #154722 (fix(lints): Improve `ill_formed_attribute_input` with better help message) - #154808 (Post-attribute ports cleanup pt. 1) - #154849 (Promote `char::is_case_ignorable` from perma-unstable to unstable) - #154850 (ast_validation: scalable vectors okay for rustdoc)
rust-bors Bot
pushed a commit
that referenced
this pull request
Apr 6, 2026
…uwer Rollup of 8 pull requests Successful merges: - #153440 (Various LTO cleanups) - #154561 (Suggest similar keyword when visibility is not followed by an item) - #154657 (Fix pattern assignment suggestions for uninitialized bindings) - #154717 (Fix ICE in unsafe binder discriminant helpers) - #154722 (fix(lints): Improve `ill_formed_attribute_input` with better help message) - #154808 (Post-attribute ports cleanup pt. 1) - #154849 (Promote `char::is_case_ignorable` from perma-unstable to unstable) - #154850 (ast_validation: scalable vectors okay for rustdoc)
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Apr 6, 2026
…Mark-Simulacrum Promote `char::is_case_ignorable` from perma-unstable to unstable (Take two of rust-lang#154658, which was closed when GitHub Codespaces somehow managed to squash the entire commit history of rust-lang/rust into one commit) This function is currently used in the implementation of `str::to_lowercase()`. There is no reason to restrict it to the stdlib, though. Reimplementations of string casing for types other than `str` -> `String` shouldn't need to waste space with a duplicate copy of this table. @rustbot label A-unicode T-libs-api r? @Mark-Simulacrum
This was referenced Apr 6, 2026
rust-bors Bot
pushed a commit
that referenced
this pull request
Apr 6, 2026
…uwer Rollup of 9 pull requests Successful merges: - #153440 (Various LTO cleanups) - #151899 (Constify fold, reduce and last for iterator) - #154561 (Suggest similar keyword when visibility is not followed by an item) - #154657 (Fix pattern assignment suggestions for uninitialized bindings) - #154717 (Fix ICE in unsafe binder discriminant helpers) - #154722 (fix(lints): Improve `ill_formed_attribute_input` with better help message) - #154777 (`#[cfg]`: suggest alternative `target_` name when the value does not match) - #154849 (Promote `char::is_case_ignorable` from perma-unstable to unstable) - #154850 (ast_validation: scalable vectors okay for rustdoc)
rust-timer
added a commit
that referenced
this pull request
Apr 6, 2026
Rollup merge of #154849 - Jules-Bertholet:case-ignorable, r=Mark-Simulacrum Promote `char::is_case_ignorable` from perma-unstable to unstable (Take two of #154658, which was closed when GitHub Codespaces somehow managed to squash the entire commit history of rust-lang/rust into one commit) This function is currently used in the implementation of `str::to_lowercase()`. There is no reason to restrict it to the stdlib, though. Reimplementations of string casing for types other than `str` -> `String` shouldn't need to waste space with a duplicate copy of this table. @rustbot label A-unicode T-libs-api r? @Mark-Simulacrum
github-actions Bot
pushed a commit
to rust-lang/miri
that referenced
this pull request
Apr 7, 2026
…uwer Rollup of 9 pull requests Successful merges: - rust-lang/rust#153440 (Various LTO cleanups) - rust-lang/rust#151899 (Constify fold, reduce and last for iterator) - rust-lang/rust#154561 (Suggest similar keyword when visibility is not followed by an item) - rust-lang/rust#154657 (Fix pattern assignment suggestions for uninitialized bindings) - rust-lang/rust#154717 (Fix ICE in unsafe binder discriminant helpers) - rust-lang/rust#154722 (fix(lints): Improve `ill_formed_attribute_input` with better help message) - rust-lang/rust#154777 (`#[cfg]`: suggest alternative `target_` name when the value does not match) - rust-lang/rust#154849 (Promote `char::is_case_ignorable` from perma-unstable to unstable) - rust-lang/rust#154850 (ast_validation: scalable vectors okay for rustdoc)
This was referenced Jun 15, 2026
jhpratt
added a commit
to jhpratt/rust
that referenced
this pull request
Jun 24, 2026
…ivate-use, r=Mark-Simulacrum Make `char::is_private_use` and `char::is_assigned` unstably public See also rust-lang#157944, rust-lang#154849. These functions are used in the implementation of `char::escape_debug()`, and there's no reason to force crates to duplicate data tables that std has to ship anyway. `is_assigned` is especially useful because crates relying on the stability guarantees of the other Unicode methods in `char` may wish to reject unassigned characters where those guarantees do not hold. I'll add a tracking issue if this is approved. The `is_assigned` vs `is_unassigned` bikeshed probably needs libs-API review before merging? @rustbot label A-Unicode T-libs-api r? @Mark-Simulacrum
jhpratt
added a commit
to jhpratt/rust
that referenced
this pull request
Jun 24, 2026
…ivate-use, r=Mark-Simulacrum Make `char::is_private_use` and `char::is_assigned` unstably public See also rust-lang#157944, rust-lang#154849. These functions are used in the implementation of `char::escape_debug()`, and there's no reason to force crates to duplicate data tables that std has to ship anyway. `is_assigned` is especially useful because crates relying on the stability guarantees of the other Unicode methods in `char` may wish to reject unassigned characters where those guarantees do not hold. I'll add a tracking issue if this is approved. The `is_assigned` vs `is_unassigned` bikeshed probably needs libs-API review before merging? @rustbot label A-Unicode T-libs-api r? @Mark-Simulacrum
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(Take two of #154658, which was closed when GitHub Codespaces somehow managed to squash the entire commit history of rust-lang/rust into one commit)
This function is currently used in the implementation of
str::to_lowercase(). There is no reason to restrict it to the stdlib, though. Reimplementations of string casing for types other thanstr->Stringshouldn't need to waste space with a duplicate copy of this table.@rustbot label A-unicode T-libs-api
r? @Mark-Simulacrum