Make char::is_private_use and char::is_assigned unstably public#157946
Open
Jules-Bertholet wants to merge 3 commits into
Open
Make char::is_private_use and char::is_assigned unstably public#157946Jules-Bertholet wants to merge 3 commits into
char::is_private_use and char::is_assigned unstably public#157946Jules-Bertholet wants to merge 3 commits into
Conversation
Member
|
I'll flag this up for libs-api review on the name (essentially I guess we can view this as an ACP). |
Member
|
Discussed in libs-api meeting, r=me with a tracking issue added. |
4 tasks
Contributor
Author
Member
|
@bors r+ rollup (Squashing in the tracking issue would be nice in the future, but no big deal). |
Contributor
jhpratt
added a commit
to jhpratt/rust
that referenced
this pull request
Jun 24, 2026
…ivate-use, r=Mark-Simulacrum Make `char::is_private_use` and `char::is_assigned` unstably public See also rust-lang#157944, rust-lang#154849. These functions are used in the implementation of `char::escape_debug()`, and there's no reason to force crates to duplicate data tables that std has to ship anyway. `is_assigned` is especially useful because crates relying on the stability guarantees of the other Unicode methods in `char` may wish to reject unassigned characters where those guarantees do not hold. I'll add a tracking issue if this is approved. The `is_assigned` vs `is_unassigned` bikeshed probably needs libs-API review before merging? @rustbot label A-Unicode T-libs-api r? @Mark-Simulacrum
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See also #157944, #154849. These functions are used in the implementation of
char::escape_debug(), and there's no reason to force crates to duplicate data tables that std has to ship anyway.is_assignedis especially useful because crates relying on the stability guarantees of the other Unicode methods incharmay wish to reject unassigned characters where those guarantees do not hold.I'll add a tracking issue if this is approved.
The
is_assignedvsis_unassignedbikeshed probably needs libs-API review before merging?@rustbot label A-Unicode T-libs-api
r? @Mark-Simulacrum