Move target checking for #[lang] to the attribute parser by JonathanBrouwer · Pull Request #158223 · rust-lang/rust

JonathanBrouwer · 2026-06-21T19:10:07Z

Work towards removing the ALL_TARGETS list.

r? @mejrs

rustbot · 2026-06-21T19:33:44Z

Some changes occurred to diagnostic attributes.

cc @mejrs

Some changes occurred in compiler/rustc_attr_parsing

cc @jdonszelmann

rustbot · 2026-06-22T15:09:52Z

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

mejrs

Aaaaaa that '_ is very infectious.

r=me if not addressing other comment

View changes since this review

mejrs · 2026-06-23T10:10:47Z

+        let allowed_targets: &[_] = if lang_item == LangItem::PanicImpl {
+            &[Allow(Target::Fn), Allow(Target::ForeignFn)]
+        } else {
+            &[Allow(lang_item.target())]
+        };


Thoughts on changing LangItem::target to return &[Target] so that we don't need to special case PanicImpl here? Although I think I can live with this if we aren't getting more multi target lang items.

#[lang = "panic_impl"] may be gone in the near future. I have a branch to replace it with an EII. It is mostly blocked on some diagnostics improvements right now.

I did it this way because the panicimpl lang item will probably soon be replaced with EEIs.
The fact that panic_impl is valid on foreign functions at all is already a complete hack, I hope this won't be used in more places

Yeah, I expect that all future cases will either use EII or #[rustc_std_internal_symbol].

JonathanBrouwer · 2026-06-23T10:33:25Z

@bors r=mejrs rollup

rust-bors · 2026-06-23T10:33:29Z

📌 Commit 9ad6dbf has been approved by mejrs

It is now in the queue for this repository.

@mejrs

Move target checking for #[lang] to the attribute parser Work towards removing the `ALL_TARGETS` list. r? @mejrs

…uwer Rollup of 16 pull requests Successful merges: - #156885 (Fix misattributed type inference error span for index expressions) - #157271 (simplify some `proc_macro` things) - #157883 (Remove strict invariant node_type on hir_type during ty privacy visit) - #157921 (trait solver: Resolve region vars in max universe) - #157960 (delegation: add support for infers in generics) - #158105 (Extract all instance shim variants into new `ShimKind` enum) - #158207 (Resolver: local/external split of `resolve_ident_in_module_non_globs_unadjusted` ) - #158279 (Follow goto and drop when linting unreachable code) - #157807 (don't ice on non-lifetime binders under `-Zassumptions-on-binders`) - #158020 (Update mingw-w64 C toolchain) - #158222 (format: ignore println newline in foreign format hints) - #158223 (Move target checking for #[lang] to the attribute parser) - #158252 (Use `cfg_select` in `std::os`) - #158257 ( fix escaping placeholder check in next solver normalization folder) - #158274 (triagebot: Stop pinging myself) - #158282 (slice_split_once: bounds check optimization note) Failed merges: - #158256 (Avoid parser panics bubbling out to proc macros)

@mejrs

Move target checking for #[lang] to the attribute parser Work towards removing the `ALL_TARGETS` list. r? @mejrs

@mejrs

Move target checking for #[lang] to the attribute parser Work towards removing the `ALL_TARGETS` list. r? @mejrs

…uwer Rollup of 23 pull requests Successful merges: - #158315 (`rust-analyzer` subtree update) - #155739 (Add temporary scope to assert_eq and assert_ne) - #156885 (Fix misattributed type inference error span for index expressions) - #157271 (simplify some `proc_macro` things) - #157883 (Remove strict invariant node_type on hir_type during ty privacy visit) - #157921 (trait solver: Resolve region vars in max universe) - #157960 (delegation: add support for infers in generics) - #157983 (Lift the same-signature restriction for `extern "tail"`) - #158105 (Extract all instance shim variants into new `ShimKind` enum) - #158207 (Resolver: local/external split of `resolve_ident_in_module_non_globs_unadjusted` ) - #158279 (Follow goto and drop when linting unreachable code) - #157527 (Move derive tests into their dedicated folder) - #157807 (don't ice on non-lifetime binders under `-Zassumptions-on-binders`) - #158020 (Update mingw-w64 C toolchain) - #158222 (format: ignore println newline in foreign format hints) - #158223 (Move target checking for #[lang] to the attribute parser) - #158252 (Use `cfg_select` in `std::os`) - #158257 ( fix escaping placeholder check in next solver normalization folder) - #158263 (Only load the feature list once in the entire resolver) - #158274 (triagebot: Stop pinging myself) - #158282 (slice_split_once: bounds check optimization note) - #158300 (Improve unknown crate_type diagnostic suggestions) - #158304 (mailmap: update mu001999) Failed merges: - #158256 (Avoid parser panics bubbling out to proc macros)

@mejrs

Move target checking for #[lang] to the attribute parser Work towards removing the `ALL_TARGETS` list. r? @mejrs

Rollup of 27 pull requests Successful merges: - #158315 (`rust-analyzer` subtree update) - #155739 (Add temporary scope to assert_eq and assert_ne) - #156885 (Fix misattributed type inference error span for index expressions) - #157271 (simplify some `proc_macro` things) - #157883 (Remove strict invariant node_type on hir_type during ty privacy visit) - #157921 (trait solver: Resolve region vars in max universe) - #157960 (delegation: add support for infers in generics) - #157983 (Lift the same-signature restriction for `extern "tail"`) - #158053 (Optimize network address parser) - #158105 (Extract all instance shim variants into new `ShimKind` enum) - #158207 (Resolver: local/external split of `resolve_ident_in_module_non_globs_unadjusted` ) - #158279 (Follow goto and drop when linting unreachable code) - #157527 (Move derive tests into their dedicated folder) - #157807 (don't ice on non-lifetime binders under `-Zassumptions-on-binders`) - #158020 (Update mingw-w64 C toolchain) - #158039 (c-variadic: test that we use equality up to free lifetimes) - #158222 (format: ignore println newline in foreign format hints) - #158223 (Move target checking for #[lang] to the attribute parser) - #158252 (Use `cfg_select` in `std::os`) - #158257 ( fix escaping placeholder check in next solver normalization folder) - #158263 (Only load the feature list once in the entire resolver) - #158267 (FromUtf8Error::into_utf8_lossy better example and suggest use) - #158274 (triagebot: Stop pinging myself) - #158282 (slice_split_once: bounds check optimization note) - #158300 (Improve unknown crate_type diagnostic suggestions) - #158304 (mailmap: update mu001999) - #158309 (Update `rustc-literal-escaper` version to `0.0.8`) Failed merges: - #158256 (Avoid parser panics bubbling out to proc macros)

@mejrs

Move target checking for #[lang] to the attribute parser Work towards removing the `ALL_TARGETS` list. r? @mejrs

rustbot added A-attributes Area: Attributes (`#[…]`, `#![…]`) S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jun 21, 2026

JonathanBrouwer force-pushed the lang-target branch from d920642 to 6f84b3b Compare June 21, 2026 19:32

rustbot assigned mejrs Jun 21, 2026

JonathanBrouwer marked this pull request as ready for review June 21, 2026 19:33

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jun 21, 2026

JonathanBrouwer force-pushed the lang-target branch from 6f84b3b to dfb0455 Compare June 21, 2026 19:41

This comment has been minimized.

Sign in to view

bjorn3 reviewed Jun 22, 2026

View reviewed changes

Comment thread compiler/rustc_passes/src/lang_items.rs Outdated

bjorn3 reviewed Jun 22, 2026

View reviewed changes

Comment thread compiler/rustc_passes/src/lang_items.rs

JonathanBrouwer added 3 commits June 22, 2026 17:09

Move target checking for #[lang] to the attribute parser

f99e894

Add lifetime parameter to AllowedTargets

b8758a3

Use AllowedTargets::ManuallyChecked for LangParser

9ad6dbf

JonathanBrouwer force-pushed the lang-target branch from dfb0455 to 9ad6dbf Compare June 22, 2026 15:09

mejrs approved these changes Jun 23, 2026

View reviewed changes

rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 23, 2026

JonathanBrouwer mentioned this pull request Jun 23, 2026

Rollup of 16 pull requests #158301

Closed

JonathanBrouwer mentioned this pull request Jun 23, 2026

Rollup of 23 pull requests #158316

Closed

JonathanBrouwer mentioned this pull request Jun 23, 2026

Rollup of 23 pull requests #158324

Closed

jhpratt added a commit to jhpratt/rust that referenced this pull request Jun 24, 2026

Rollup merge of rust-lang#158223 - JonathanBrouwer:lang-target, r=mejrs

399855f

Move target checking for #[lang] to the attribute parser Work towards removing the `ALL_TARGETS` list. r? @mejrs

jhpratt mentioned this pull request Jun 24, 2026

Rollup of 27 pull requests #158335

Closed

jhpratt added a commit to jhpratt/rust that referenced this pull request Jun 24, 2026

Rollup merge of rust-lang#158223 - JonathanBrouwer:lang-target, r=mejrs

fe2bfaf

Move target checking for #[lang] to the attribute parser Work towards removing the `ALL_TARGETS` list. r? @mejrs

jhpratt mentioned this pull request Jun 24, 2026

Rollup of 34 pull requests #158337

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Move target checking for #[lang] to the attribute parser#158223

Move target checking for #[lang] to the attribute parser#158223
JonathanBrouwer wants to merge 3 commits into
rust-lang:mainfrom
JonathanBrouwer:lang-target

JonathanBrouwer commented Jun 21, 2026 •

edited

Loading

Uh oh!

rustbot commented Jun 21, 2026

Uh oh!

This comment has been minimized.

Uh oh!

Uh oh!

rustbot commented Jun 22, 2026

Uh oh!

mejrs left a comment •

edited by rustbot

Loading

Uh oh!

mejrs Jun 23, 2026

Uh oh!

bjorn3 Jun 23, 2026

Uh oh!

JonathanBrouwer Jun 23, 2026 •

edited

Loading

Uh oh!

bjorn3 Jun 23, 2026

Uh oh!

JonathanBrouwer commented Jun 23, 2026

Uh oh!

rust-bors Bot commented Jun 23, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Conversation

JonathanBrouwer commented Jun 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rustbot commented Jun 21, 2026

Uh oh!

This comment has been minimized.

Uh oh!

Uh oh!

rustbot commented Jun 22, 2026

Uh oh!

mejrs left a comment • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mejrs Jun 23, 2026

Choose a reason for hiding this comment

Uh oh!

bjorn3 Jun 23, 2026

Choose a reason for hiding this comment

Uh oh!

JonathanBrouwer Jun 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

bjorn3 Jun 23, 2026

Choose a reason for hiding this comment

Uh oh!

JonathanBrouwer commented Jun 23, 2026

Uh oh!

rust-bors Bot commented Jun 23, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

JonathanBrouwer commented Jun 21, 2026 •

edited

Loading

mejrs left a comment •

edited by rustbot

Loading

JonathanBrouwer Jun 23, 2026 •

edited

Loading