FromUtf8Error::into_utf8_lossy better example and suggest use#158267
Open
tisonkun wants to merge 1 commit into
Open
FromUtf8Error::into_utf8_lossy better example and suggest use#158267tisonkun wants to merge 1 commit into
tisonkun wants to merge 1 commit into
Conversation
Collaborator
|
|
tgross35
reviewed
Jun 22, 2026
This comment has been minimized.
This comment has been minimized.
tisonkun
commented
Jun 23, 2026
tgross35
approved these changes
Jun 23, 2026
Contributor
There was a problem hiding this comment.
Looks great! Squashing into the first...
@bors squash msg="FromUtf8Error::into_utf8_lossy better example and suggest use
Signed-off-by: tison wander4096@gmail.com"
Contributor
|
Unclosed quote in argument. Run |
Contributor
|
Okay then @bors squash msg="FromUtf8Error::into_utf8_lossy better example and suggest use" |
This comment has been minimized.
This comment has been minimized.
Contributor
|
🔨 2 commits were squashed into 2dad1f8. |
5e3a421 to
2dad1f8
Compare
Contributor
|
@bors r+ rollup |
Contributor
Collaborator
|
A job failed! Check out the build log: (web) (plain enhanced) (plain) Click to see the possible cause of the failure (guessed by this bot) |
Contributor
|
^ spurious failure |
jhpratt
added a commit
to jhpratt/rust
that referenced
this pull request
Jun 24, 2026
FromUtf8Error::into_utf8_lossy better example and suggest use This handles rust-lang#129436 (comment) and refers to https://github.com/rust-lang/rust/pull/129439/changes#r1763510354 r? @tgross35
rust-bors Bot
pushed a commit
that referenced
this pull request
Jun 24, 2026
Rollup of 27 pull requests Successful merges: - #158315 (`rust-analyzer` subtree update) - #155739 (Add temporary scope to assert_eq and assert_ne) - #156885 (Fix misattributed type inference error span for index expressions) - #157271 (simplify some `proc_macro` things) - #157883 (Remove strict invariant node_type on hir_type during ty privacy visit) - #157921 (trait solver: Resolve region vars in max universe) - #157960 (delegation: add support for infers in generics) - #157983 (Lift the same-signature restriction for `extern "tail"`) - #158053 (Optimize network address parser) - #158105 (Extract all instance shim variants into new `ShimKind` enum) - #158207 (Resolver: local/external split of `resolve_ident_in_module_non_globs_unadjusted` ) - #158279 (Follow goto and drop when linting unreachable code) - #157527 (Move derive tests into their dedicated folder) - #157807 (don't ice on non-lifetime binders under `-Zassumptions-on-binders`) - #158020 (Update mingw-w64 C toolchain) - #158039 (c-variadic: test that we use equality up to free lifetimes) - #158222 (format: ignore println newline in foreign format hints) - #158223 (Move target checking for #[lang] to the attribute parser) - #158252 (Use `cfg_select` in `std::os`) - #158257 ( fix escaping placeholder check in next solver normalization folder) - #158263 (Only load the feature list once in the entire resolver) - #158267 (FromUtf8Error::into_utf8_lossy better example and suggest use) - #158274 (triagebot: Stop pinging myself) - #158282 (slice_split_once: bounds check optimization note) - #158300 (Improve unknown crate_type diagnostic suggestions) - #158304 (mailmap: update mu001999) - #158309 (Update `rustc-literal-escaper` version to `0.0.8`) Failed merges: - #158256 (Avoid parser panics bubbling out to proc macros)
jhpratt
added a commit
to jhpratt/rust
that referenced
this pull request
Jun 24, 2026
FromUtf8Error::into_utf8_lossy better example and suggest use This handles rust-lang#129436 (comment) and refers to https://github.com/rust-lang/rust/pull/129439/changes#r1763510354 r? @tgross35
jhpratt
added a commit
to jhpratt/rust
that referenced
this pull request
Jun 24, 2026
FromUtf8Error::into_utf8_lossy better example and suggest use This handles rust-lang#129436 (comment) and refers to https://github.com/rust-lang/rust/pull/129439/changes#r1763510354 r? @tgross35
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This handles #129436 (comment) and refers to https://github.com/rust-lang/rust/pull/129439/changes#r1763510354
r? @tgross35