Rollup of 23 pull requests by JonathanBrouwer · Pull Request #158316 · rust-lang/rust

JonathanBrouwer · 2026-06-23T17:45:00Z

Successful merges:

Added implementation on set_permissions_nofollow for all primary platforms #158168 (Added implementation on set_permissions_nofollow for all primary platforms)
Add temporary scope to assert_eq and assert_ne #155739 (Add temporary scope to assert_eq and assert_ne)
Fix misattributed type inference error span for index expressions #156885 (Fix misattributed type inference error span for index expressions)
simplify some proc_macro things #157271 (simplify some proc_macro things)
Remove strict invariant node_type on hir_type during ty privacy visit #157883 (Remove strict invariant node_type on hir_type during ty privacy visit)
trait solver: Resolve region vars in max universe #157921 (trait solver: Resolve region vars in max universe)
delegation: add support for infers in generics #157960 (delegation: add support for infers in generics)
Lift the same-signature restriction for extern "tail" #157983 (Lift the same-signature restriction for extern "tail")
Extract all instance shim variants into new ShimKind enum #158105 (Extract all instance shim variants into new ShimKind enum)
Resolver: local/external split of resolve_ident_in_module_non_globs_unadjusted #158207 (Resolver: local/external split of resolve_ident_in_module_non_globs_unadjusted )
Follow goto and drop when linting unreachable code #158279 (Follow goto and drop when linting unreachable code)
Move derive tests into their dedicated folder #157527 (Move derive tests into their dedicated folder)
don't ice on non-lifetime binders under -Zassumptions-on-binders #157807 (don't ice on non-lifetime binders under -Zassumptions-on-binders)
Update mingw-w64 C toolchain #158020 (Update mingw-w64 C toolchain)
format: ignore println newline in foreign format hints #158222 (format: ignore println newline in foreign format hints)
Move target checking for #[lang] to the attribute parser #158223 (Move target checking for #[lang] to the attribute parser)
Use cfg_select in std::os #158252 (Use cfg_select in std::os)
fix escaping placeholder check in next solver normalization folder #158257 ( fix escaping placeholder check in next solver normalization folder)
Only load the feature list once in the entire resolver #158263 (Only load the feature list once in the entire resolver)
triagebot: Stop pinging myself #158274 (triagebot: Stop pinging myself)
slice_split_once: bounds check optimization note #158282 (slice_split_once: bounds check optimization note)
Improve unknown crate_type diagnostic suggestions #158300 (Improve unknown crate_type diagnostic suggestions)
mailmap: update mu001999 #158304 (mailmap: update mu001999)

Failed merges:

Avoid parser panics bubbling out to proc macros #158256 (Avoid parser panics bubbling out to proc macros)

When an index expression with an ambiguous type (e.g. `arr[idx.into()]`) appears inside a cast or binary operation, the type inference error was incorrectly attributed to the outer expression instead of the `.into()` call. Resolve the index sub-expression type first so the error points at the actual ambiguous site.

The region-constraint machinery for `-Zassumptions-on-binders` is region-outlives-only. A non-lifetime binder (`for<T>`) introduces a placeholder type in the binder's universe `u`. The rewrite that pulls constraints out of `u` only folds regions (`PlaceholderReplacer` just implements `fold_region`), so an alias-outlives constraint such as `<!T as Trait>::Assoc: 'r` reaches `pull_region_outlives_constraints_out_of_universe` still in `u` and trips `assert!(max_universe < u)`. Report ambiguity for those constraints instead of asserting, matching the existing `None => Ambiguity` bail-outs in this module. The goal then surfaces as an ordinary ambiguity error rather than an ICE.

The `MaxUniverse` region visitor matched on `ReVar` terms and unwrapped `universe_of_lt`, which returns `None` for a variable that has already been unified with another region. Such resolved variables can reach the visitor while computing region assumptions under `-Zassumptions-on-binders`, causing an ICE. Resolve the variable first and inspect whatever it points at instead of assuming it is still an unresolved inference variable.

Adjust ambiguous index diagnostics without adding new index operand resolution points. Keep invalid operator and mismatched operand diagnostics on the operator while still pointing valid ambiguous index cases at the index operand.

…er expected enum diagnostics

…p lowering

…xternal `module` variants.

They tend to have similar handling -- e.g., they should be the only input to the `mir_shims` query -- so it's cleaner to group them together. This will also make potential future refactorings easier, such as only carrying `GenericArgsRef` for instances that actually use it (e.g., `Item`) but not others (e.g., `CloneShim`). Many of the shim variants still have `Shim` at the end of their names. To make the refactoring easier and keep the diff clean, I will trim those suffixes off in the next commit.

JonathanBrouwer · 2026-06-23T17:45:09Z

@bors r+ rollup=never p=5

Trying commonly failed jobs
@bors try jobs=dist-various-1,test-various,x86_64-gnu-aux,x86_64-gnu-llvm-21-3,x86_64-msvc-1,aarch64-apple,x86_64-mingw-1,i686-msvc-2

rust-bors · 2026-06-23T17:45:13Z

📌 Commit 04e4c9b has been approved by JonathanBrouwer

It is now in the queue for this repository.

rust-bors · 2026-06-23T17:45:18Z

⌛ Trying commit 04e4c9b with merge 89c2b53…

To cancel the try build, run the command @bors try cancel.

Workflow: https://github.com/rust-lang/rust/actions/runs/28045422763

Rollup of 23 pull requests try-job: dist-various-1 try-job: test-various try-job: x86_64-gnu-aux try-job: x86_64-gnu-llvm-21-3 try-job: x86_64-msvc-1 try-job: aarch64-apple try-job: x86_64-mingw-1 try-job: i686-msvc-2

JonathanBrouwer · 2026-06-23T17:46:02Z

@bors try cancel
@bors try jobs=dist-various-1,test-various,x86_64-gnu-aux,x86_64-gnu-llvm-21-3,x86_64-msvc-1,aarch64-apple,x86_64-mingw-1,i686-msvc-2,dist-i686-msvc

rust-bors · 2026-06-23T17:46:08Z

Try build cancelled. Cancelled workflows:

https://github.com/rust-lang/rust/actions/runs/28045422763

rust-bors · 2026-06-23T17:46:12Z

⌛ Trying commit 04e4c9b with merge 0b522ab…

To cancel the try build, run the command @bors try cancel.

Workflow: https://github.com/rust-lang/rust/actions/runs/28045473236

Rollup of 23 pull requests try-job: dist-various-1 try-job: test-various try-job: x86_64-gnu-aux try-job: x86_64-gnu-llvm-21-3 try-job: x86_64-msvc-1 try-job: aarch64-apple try-job: x86_64-mingw-1 try-job: i686-msvc-2 try-job: dist-i686-msvc

rust-log-analyzer · 2026-06-23T18:47:43Z

The job dist-various-1 failed! Check out the build log: (web) (plain enhanced) (plain)

Click to see the possible cause of the failure (guessed by this bot)


error[E0425]: cannot find value `AT_SYMLINK_NOFOLLOW` in crate `libc`
    --> /rustc/0b522ab0b9875b7cc5cb375ba5ec65db09bbada8/library/std/src/sys/fs/unix.rs:2016:77
     |
2016 |                 libc::fchmodat(libc::AT_FDCWD, p.as_ptr(), perm.mode, libc::AT_SYMLINK_NOFOLLOW)
     |                                                                             ^^^^^^^^^^^^^^^^^^^ not found in `libc`

For more information about this error, try `rustc --explain E0425`.
[RUSTC-TIMING] std test:false 2.688
warning: `std` (lib) generated 1 warning

rust-bors · 2026-06-23T18:49:55Z

PR #158168, which is a member of this rollup, was unapproved.

This rollup was thus unapproved.

JonathanBrouwer · 2026-06-23T18:50:36Z

@bors try cancel

rust-bors · 2026-06-23T18:50:40Z

Try build cancelled. Cancelled workflows:

https://github.com/rust-lang/rust/actions/runs/28045473236

Voultapher and others added 30 commits April 24, 2026 14:59

Add temporary scope to assert_eq and assert_ne

51f42d6

This is a follow-up to rust-lang#155431

remove some redundant closures

5ffbf04

simplify Buffer

acac5b3

set issue = none for proc_macro_internals

d727a0e

fix "rountrips" typo

b292ff8

improve nonfatal-parsing test

30004a8

Update mingw-w64 C toolchain

b1483e3

Move derive tests out of tests/ui/issues

b1403bc

add issue links and bless

68f9f5a

Avoid forcing index operand inference

a09fc01

Adjust ambiguous index diagnostics without adding new index operand resolution points. Keep invalid operator and mismatched operand diagnostics on the operator while still pointing valid ambiguous index cases at the index operand.

Handle alias outlives ambiguity during rewrite

a2f80c9

Resolve vars before computing max universe

3bb0a1c

Format max universe visitor

a44ab8d

Ignore println newline in foreign format hints

e7b8d13

Update foreign format UI baselines

56dfba7

Correct issue 92267 UI baseline

356c63f

Update issue 92267 stderr ending

2a86b91

Add tup expr arg unbounded assoc const test and update test with prop…

b1e1db9

…er expected enum diagnostics

typo fix from hid_id to hir_id

f0cf392

Check the target and souce tuple elements mismatch duing const_arg_tu…

cd8c4d0

…p lowering

norm: fix escaping placeholder check

3da4612

Move target checking for #[lang] to the attribute parser

f99e894

Add lifetime parameter to AllowedTargets

b8758a3

Use AllowedTargets::ManuallyChecked for LangParser

9ad6dbf

Split resolve_ident_in_module_non_globs_unadjusted into local and e…

6863281

…xternal `module` variants.

Strip vestigial Shim suffix from ShimKind variants

c329a0e

rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 23, 2026

JonathanBrouwer mentioned this pull request Jun 23, 2026

Added implementation on set_permissions_nofollow for all primary platforms #158168

Open

rust-bors Bot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jun 23, 2026

JonathanBrouwer closed this Jun 23, 2026

rustbot removed the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Jun 23, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Rollup of 23 pull requests#158316

Rollup of 23 pull requests#158316
JonathanBrouwer wants to merge 65 commits into
rust-lang:mainfrom
JonathanBrouwer:rollup-5CEu820

JonathanBrouwer commented Jun 23, 2026

Uh oh!

JonathanBrouwer commented Jun 23, 2026

Uh oh!

rust-bors Bot commented Jun 23, 2026

Uh oh!

rust-bors Bot commented Jun 23, 2026 •

edited

Loading

Uh oh!

JonathanBrouwer commented Jun 23, 2026

Uh oh!

rust-bors Bot commented Jun 23, 2026

Uh oh!

rust-bors Bot commented Jun 23, 2026 •

edited

Loading

Uh oh!

rust-log-analyzer commented Jun 23, 2026

Uh oh!

rust-bors Bot commented Jun 23, 2026

Uh oh!

JonathanBrouwer commented Jun 23, 2026

Uh oh!

rust-bors Bot commented Jun 23, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

20 participants

Uh oh!

Conversation

JonathanBrouwer commented Jun 23, 2026

Uh oh!

JonathanBrouwer commented Jun 23, 2026

Uh oh!

rust-bors Bot commented Jun 23, 2026

Uh oh!

rust-bors Bot commented Jun 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

JonathanBrouwer commented Jun 23, 2026

Uh oh!

rust-bors Bot commented Jun 23, 2026

Uh oh!

rust-bors Bot commented Jun 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rust-log-analyzer commented Jun 23, 2026

Uh oh!

rust-bors Bot commented Jun 23, 2026

Uh oh!

JonathanBrouwer commented Jun 23, 2026

Uh oh!

rust-bors Bot commented Jun 23, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

20 participants

rust-bors Bot commented Jun 23, 2026 •

edited

Loading

rust-bors Bot commented Jun 23, 2026 •

edited

Loading