feat: migrate to latest oclif version by Souvikns · Pull Request #203 · asyncapi/cli

Souvikns · 2022-01-27T15:34:09Z

Description
This PR aims to migrate to the new oclif version and also remove other unnecessary packages, and follow the new doc by oclif.

Related issue(s)

See also #192

Souvikns · 2022-02-07T02:56:50Z

I modeled my PR based on the current boilerplate that oclif generates when we create a new project. packages like @oclif/command, @oclif/config have been merged into @oclf/core. Functionality did not change much just needed to update the imports and that's all.

Some things changed like

Now we can not access this._help() to show the command level help. I couldn't find resources to how we can achieve this now. Opened an Issue asking about this How do I access command help inside command itself? oclif/core#360.
Now topics are treated separately and https://oclif.io/docs/topics and also has inbuilt support for topic separators so we don not need third party plugins now.

magicmatatjahu · 2022-02-07T09:52:36Z

@Souvikns Do you want to wait for feedback in oclif/core#360 issue? Also I wonder if we should go with chore: prefix because if we merge it and then try to merge another PRs we won't that help support, so I guess that we will have inconsistent in the code, right? Sorry I'm not up to date with CLI code, so I don't know.

Souvikns · 2022-02-07T13:29:37Z

@Souvikns Do you want to wait for feedback in oclif/core#360 issue? Also I wonder if we should go with chore: prefix because if we merge it and then try to merge another PRs we won't that help support, so I guess that we will have inconsistent in the code, right? Sorry I'm not up to date with CLI code, so I don't know.

I do want to wait for the reply but then again the CLI is showing warnings in production I am kinda confused on what should we do here.

Also topic help works but the command is slightly changed
Before
asyncapi start would show the topic level help
Now
needs asyncapi start --help to show help

magicmatatjahu · 2022-02-09T10:51:10Z

@Souvikns Sorry for that delayed response.

Hmmm 🤔 Ok, I understand. However, I have still that afraid with merging it, because we have a lot opened PRs and even if we merge it as chore: and then try to fix problems as fast as possible, other people will have to wait for us. cc @derberg

Souvikns · 2022-02-09T11:10:28Z

Maybe we wait and let others finish and then merge it, that way we don't block anyone.

Souvikns · 2022-02-10T14:47:59Z

@magicmatatjahu found a way to show command help for topics all thanks to oclif/core#360 Now everything works like before.

magicmatatjahu · 2022-02-11T14:07:44Z

@Souvikns

Maybe we wait and let others finish and then merge it, that way we don't block anyone.

I prefer that option. Of course we should wait only for some PRs, not for everyone, that PRs which is very close to merge :)

found a way to show command help for topics all thanks to oclif/core#360 Now everything works like before.

Awesome!

Souvikns · 2022-02-24T05:57:44Z

@magicmatatjahu shall we merge this, #244 I think people are having issues. I can help all other PR's with the changes that they might need to do.

magicmatatjahu · 2022-02-28T11:27:00Z

@Souvikns I checked your changes locally and CLI works as expected :) However if we merge it we need focus on fixing problems and release new version in a short time. I can help with opened PRs, but without a release some issues will not be fixed.

@derberg What do you think?

magicmatatjahu · 2022-03-02T10:48:31Z

@Souvikns Could we merge it as feat:? I've already forgotten, but what's stopping us from releasing the new version?

Souvikns · 2022-03-02T10:50:23Z

Once we merge this all other open PRs will have conflict, nothing other than that.

sonarqubecloud · 2022-03-02T10:51:03Z

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication

derberg · 2022-03-02T10:58:53Z

we need to release it, not just merge. I recommend feat: prefix

magicmatatjahu · 2022-03-02T11:04:34Z

@Souvikns

Once we merge this all other open PRs will have conflict, nothing other than that.

But we can help people to fix their PRs, this's not problem :)

derberg · 2022-03-02T11:41:29Z

@magicmatatjahu did you review it already? do I have to look at something?

magicmatatjahu · 2022-03-02T11:45:34Z

@derberg I checked it locally and it works :) We can merge it.

derberg · 2022-03-02T11:56:38Z

@magicmatatjahu then why didn't you approve it? 😆

magicmatatjahu

@derberg I'm waiting for you to make a move 😆

@Souvikns Awesome work! We should add info the slack that we merge that PR and people should fix their PRs, of course we can help them.

derberg · 2022-03-02T11:59:39Z

Souvikns · 2022-03-02T12:03:27Z

/rtm

* docs: fix missing toc (asyncapi#230) * feat: add global specification watcher (asyncapi#220) Co-authored-by: Lukasz Gornicki <lpgornicki@gmail.com> Co-authored-by: Maciej Urbańczyk <urbanczyk.maciej.95@gmail.com> * chore(release): v0.14.0 (asyncapi#237) * docs: add imabp as a contributor for code (asyncapi#239) Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com> * fix: update @asyncapi/studio to 0.10.0 version (asyncapi#241) * chore(release): v0.14.1 (asyncapi#242) * feat: added testing for new (asyncapi#212) * docs: add Samridhi-98 as a contributor for test (asyncapi#248) * ci: update global workflows (asyncapi#246) * chore(release): v0.15.0 (asyncapi#249) * feat: migrate to latest oclif version (asyncapi#203) * chore: update bot name from codeowners file (asyncapi#247) * ci: update global workflows (asyncapi#250) * Create test.yml * Update test.yml * Update test.yml * Update test.yml * Update test.yml Co-authored-by: Abir <abir.pal899@gmail.com> Co-authored-by: Lukasz Gornicki <lpgornicki@gmail.com> Co-authored-by: Maciej Urbańczyk <urbanczyk.maciej.95@gmail.com> Co-authored-by: asyncapi-bot <61865014+asyncapi-bot@users.noreply.github.com> Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com> Co-authored-by: Samriddhi <Agrawalsamriddhi83@gmail.com> Co-authored-by: asyncapi-bot <bot+chan@asyncapi.io>

asyncapi-bot · 2022-03-11T11:59:28Z

🎉 This PR is included in version 0.16.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

chore: migrate to latest oclif version

4e7b26b

Souvikns mentioned this pull request Jan 31, 2022

readme is missing documentation for the new commands #123

Closed

chore: add test env

f4b4ef9

Souvikns marked this pull request as ready for review January 31, 2022 12:50

Souvikns added 2 commits January 31, 2022 18:47

chore: fix test

a323c53

fix: lint fixes

4aa3307

Souvikns mentioned this pull request Feb 4, 2022

feat: add new convert command to CLI #188

Merged

Souvikns added 3 commits February 7, 2022 08:04

feat: update to latest packages.

48f504e

Merge remote-tracking branch 'upstream/master' into oclif-migration

6d0c93e

chore: fix lint issues

e74157a

Souvikns requested review from derberg and magicmatatjahu February 7, 2022 02:57

feat: add support for topic command help

db5923b

Souvikns added 2 commits February 10, 2022 20:25

Merge remote-tracking branch 'upstream/master' into oclif-migration

531c3a4

chore: convert diff command to latest oclif version

0e02db9

Souvikns mentioned this pull request Feb 21, 2022

Validation for available commands. #70

Closed

Souvikns added 2 commits February 22, 2022 17:09

Merge remote-tracking branch 'upstream/master' into oclif-migration

393b418

Update flags.ts

770b898

Souvikns mentioned this pull request Feb 23, 2022

Studio 404 not found #244

Closed

Merge branch 'master' into oclif-migration

5614674

Souvikns changed the title ~~chore: migrate to latest oclif version~~ feat: migrate to latest oclif version Mar 2, 2022

magicmatatjahu approved these changes Mar 2, 2022

View reviewed changes

asyncapi-bot added the ready-to-merge label Mar 2, 2022

asyncapi-bot merged commit 33d0eb5 into asyncapi:master Mar 2, 2022

This was referenced Mar 7, 2022

CLI is breaking in production! #192

Closed

feat: add validation modules in cli for command validation #243

Merged

asyncapi-bot added the released label Mar 11, 2022

Uh oh!

Uh oh!

Conversation

Souvikns commented Jan 27, 2022

Uh oh!

Souvikns commented Feb 7, 2022

Uh oh!

magicmatatjahu commented Feb 7, 2022

Uh oh!

Souvikns commented Feb 7, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

magicmatatjahu commented Feb 9, 2022

Uh oh!

Souvikns commented Feb 9, 2022

Uh oh!

Souvikns commented Feb 10, 2022

Uh oh!

magicmatatjahu commented Feb 11, 2022

Uh oh!

Souvikns commented Feb 24, 2022

Uh oh!

magicmatatjahu commented Feb 28, 2022

Uh oh!

magicmatatjahu commented Mar 2, 2022

Uh oh!

Souvikns commented Mar 2, 2022

Uh oh!

sonarqubecloud Bot commented Mar 2, 2022

Uh oh!

derberg commented Mar 2, 2022

Uh oh!

magicmatatjahu commented Mar 2, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

derberg commented Mar 2, 2022

Uh oh!

magicmatatjahu commented Mar 2, 2022

Uh oh!

derberg commented Mar 2, 2022

Uh oh!

magicmatatjahu left a comment

Choose a reason for hiding this comment

Uh oh!

derberg commented Mar 2, 2022

Uh oh!

Souvikns commented Mar 2, 2022

Uh oh!

asyncapi-bot commented Mar 11, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Souvikns commented Feb 7, 2022 •

edited

Loading

magicmatatjahu commented Mar 2, 2022 •

edited

Loading