Skip to content

docs: fix missing toc#230

Merged
asyncapi-bot merged 1 commit into
asyncapi:masterfrom
Souvikns:toc-fix
Feb 18, 2022
Merged

docs: fix missing toc#230
asyncapi-bot merged 1 commit into
asyncapi:masterfrom
Souvikns:toc-fix

Conversation

@Souvikns

@Souvikns Souvikns commented Feb 11, 2022

Copy link
Copy Markdown
Member

Description

For some reason, the TOC is not generated in README.md. Just manually creating it in this PR.

@sonarqubecloud

sonarqubecloud Bot commented Feb 11, 2022

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@magicmatatjahu

magicmatatjahu commented Feb 14, 2022

Copy link
Copy Markdown
Member

@Souvikns Did you run manually generate:markdown:toc? I think that we have some problem on the workflow side and we should try to make it by merging PR.

@Souvikns

Souvikns commented Feb 14, 2022 •
edited
Loading

Copy link
Copy Markdown
Member Author

@Souvikns Did you run manually generate:markdown:toc? I think that we have some problem on the workflow side and we should try to make it by merging PR.

Yeah, I just ran the command and pushed I figured something was wrong with the workflow because we have a command for this, but was not able to find it out.

@magicmatatjahu

magicmatatjahu commented Feb 18, 2022

Copy link
Copy Markdown
Member

@Souvikns Yeah we have that here https://github.com/asyncapi/cli/blob/master/.github/workflows/if-nodejs-version-bump.yml#L31 I also wonder why it didn't run on the post release workflow 🤔 I can accept that changes because I don't think so that we should wait for that, but please rerun again the markdown-toc generation because maybe there are some changes in the master and ping me, ok? :)

@Souvikns

Souvikns commented Feb 18, 2022

Copy link
Copy Markdown
Member Author

@magicmatatjahu I just rerun and there aren't any new changes and the branch is up to date with upstream/master

@Souvikns

Souvikns commented Feb 18, 2022

Copy link
Copy Markdown
Member Author

/rtm

@asyncapi-bot asyncapi-bot merged commit 663b260 into asyncapi:master Feb 18, 2022
@asyncapi-bot

asyncapi-bot commented Feb 21, 2022

Copy link
Copy Markdown
Contributor

🎉 This PR is included in version 0.14.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Souvikns added a commit to Souvikns/cli that referenced this pull request Mar 8, 2022
@Souvikns @imabp
@derberg @magicmatatjahu @asyncapi-bot @allcontributors @Samridhi-98
Prepack fix (#1)
994e294 
* docs: fix missing toc (asyncapi#230)

* feat: add global specification watcher (asyncapi#220)

Co-authored-by: Lukasz Gornicki <lpgornicki@gmail.com>
Co-authored-by: Maciej Urbańczyk <urbanczyk.maciej.95@gmail.com>

* chore(release): v0.14.0 (asyncapi#237)

* docs: add imabp as a contributor for code (asyncapi#239)

Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com>

* fix: update @asyncapi/studio to 0.10.0 version (asyncapi#241)

* chore(release): v0.14.1 (asyncapi#242)

* feat: added testing for new (asyncapi#212)

* docs: add Samridhi-98 as a contributor for test (asyncapi#248)

* ci: update global workflows (asyncapi#246)

* chore(release): v0.15.0 (asyncapi#249)

* feat: migrate to latest oclif version (asyncapi#203)

* chore: update bot name from codeowners file (asyncapi#247)

* ci: update global workflows (asyncapi#250)

* Create test.yml

* Update test.yml

* Update test.yml

* Update test.yml

* Update test.yml

Co-authored-by: Abir <abir.pal899@gmail.com>
Co-authored-by: Lukasz Gornicki <lpgornicki@gmail.com>
Co-authored-by: Maciej Urbańczyk <urbanczyk.maciej.95@gmail.com>
Co-authored-by: asyncapi-bot <61865014+asyncapi-bot@users.noreply.github.com>
Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com>
Co-authored-by: Samriddhi <Agrawalsamriddhi83@gmail.com>
Co-authored-by: asyncapi-bot <bot+chan@asyncapi.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@magicmatatjahu magicmatatjahu magicmatatjahu approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

ready-to-merge released

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Souvikns @magicmatatjahu @asyncapi-bot