feat: add global specification watcher by imabp · Pull Request #220 · asyncapi/cli

imabp · 2022-02-08T20:37:17Z

Description

Adds Global Watcher for Specification

Related issue(s)
#73

imabp · 2022-02-09T05:10:33Z

I guess there is an error with, test case for watch mode.
The fs stream is not getting closed. I will try to create a mock stream and then close it from tests
Apologies, the test ran for 4 hours.

derberg

Please also enable watcher for diff

@Souvikns @boyney123 @magicmatatjahu wanna have a look?

Co-authored-by: Lukasz Gornicki <lpgornicki@gmail.com>

imabp · 2022-02-09T09:05:55Z

Hey @derberg watch flag is added to diff :)
Kindly review :)

magicmatatjahu

Awesome! I leave some comments, please refer to them.

…atch

magicmatatjahu

@imabp Good, but you have to handle that one code smell :) https://sonarcloud.io/project/issues?id=asyncapi_cli&open=AX7bDmqtPXvNfWF5cO0t&pullRequest=220&resolved=false&types=CODE_SMELL

Also please refer to my and Łukasz suggestion: https://github.com/asyncapi/cli/pull/220/files#r802512653

imabp · 2022-02-09T11:07:48Z

Hey @magicmatatjahu the code smell is fixed :)

derberg

OH man, what an improvement, it looks much cleaner now. I left only 2 comments

imabp · 2022-02-10T10:20:59Z

Hey @derberg @magicmatatjahu
Please check the latest changes, of auto-disabling watch mode. Here is a screenshot

derberg

looking good, except for one followup comments I guess we are still left with an idea on testing watcher?

I'm also wondering if we do not need unit tests for commands where watcher is used. Like what happens for example when user passes --watch and both AsyncAPI references are URLs. Do we perform validation/diff> IMHO yes, but then we need to have it tested imho as well

Co-authored-by: Lukasz Gornicki <lpgornicki@gmail.com>

imabp · 2022-02-18T13:20:47Z

Sure @magicmatatjahu here is the new issue, we can work on that. :)
#234

imabp · 2022-02-18T13:29:05Z

Just a question, @magicmatatjahu then shall we proceed with this PR, and then address the issue of handling errors #234 ?
Or
Work on #234 and let this PR be on hold. ?

magicmatatjahu · 2022-02-18T13:30:03Z

@imabp First complete that PR and then start working on mentioned issue :) You can propagate changes from that comment and I will accept it. #220 (comment)

imabp · 2022-02-18T13:36:23Z

I have fixed the second error as you mentioned @magicmatatjahu and is now reflected in the latest changes

another problem: when I provide some changes in the watched file I always see Watching AsyncAPI file at ./sample.yaml on every change. We should remove 40 line from specWatcher function:

Here are the checks

magicmatatjahu · 2022-02-18T13:41:08Z

@imabp Probably we don't understand each other 😆 I had in mind this one:

imabp · 2022-02-18T13:43:18Z

Ohh I got it.. 😅 . .Its really a learning to converse on PRs 😄 specially on such highly-critical issues
Implementing inside the catch(err) block, sure I will go through that..

imabp · 2022-02-18T14:14:33Z

Hey @magicmatatjahu
Everything seems to work well now 😄
Checked on node LTS

magicmatatjahu

Last thing :)

sonarqubecloud · 2022-02-21T11:21:43Z

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication

magicmatatjahu

LGTM! However I see little "bug" when I run diff command. When I have invalid spec I cannot recognize in which file I have errors (in new or old?):

We should improve logs in the followup PR @imabp Could you handle that? We need that PR for another commands so I don't want to block development with rejection.

magicmatatjahu · 2022-02-21T12:14:13Z

/rtm

imabp · 2022-02-21T12:21:30Z

Yes sure!! @magicmatatjahu We need a proper logging control center 😅 or an interface

I am creating a issue #236
We can work on this after fixing #234

asyncapi-bot · 2022-02-21T12:23:24Z

🎉 This PR is included in version 0.14.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

imabp · 2022-02-21T13:22:08Z

@all-contributors please add @imabp for code

allcontributors · 2022-02-21T13:22:17Z

@imabp

I've put up a pull request to add @imabp! 🎉

imabp · 2022-02-21T13:23:14Z

I gave it a try, and it worked out xD 😂😂

* docs: fix missing toc (asyncapi#230) * feat: add global specification watcher (asyncapi#220) Co-authored-by: Lukasz Gornicki <lpgornicki@gmail.com> Co-authored-by: Maciej Urbańczyk <urbanczyk.maciej.95@gmail.com> * chore(release): v0.14.0 (asyncapi#237) * docs: add imabp as a contributor for code (asyncapi#239) Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com> * fix: update @asyncapi/studio to 0.10.0 version (asyncapi#241) * chore(release): v0.14.1 (asyncapi#242) * feat: added testing for new (asyncapi#212) * docs: add Samridhi-98 as a contributor for test (asyncapi#248) * ci: update global workflows (asyncapi#246) * chore(release): v0.15.0 (asyncapi#249) * feat: migrate to latest oclif version (asyncapi#203) * chore: update bot name from codeowners file (asyncapi#247) * ci: update global workflows (asyncapi#250) * Create test.yml * Update test.yml * Update test.yml * Update test.yml * Update test.yml Co-authored-by: Abir <abir.pal899@gmail.com> Co-authored-by: Lukasz Gornicki <lpgornicki@gmail.com> Co-authored-by: Maciej Urbańczyk <urbanczyk.maciej.95@gmail.com> Co-authored-by: asyncapi-bot <61865014+asyncapi-bot@users.noreply.github.com> Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com> Co-authored-by: Samriddhi <Agrawalsamriddhi83@gmail.com> Co-authored-by: asyncapi-bot <bot+chan@asyncapi.io>

feat: add global specification watcher

58634a9

imabp mentioned this pull request Feb 8, 2022

add watch option #73

Closed

imabp added 2 commits February 9, 2022 12:13

fix: temporary remove test for watch mode

fdd4413

fix:lint

300a068

derberg suggested changes Feb 9, 2022

View reviewed changes

Comment thread src/globals.ts Outdated

Comment thread src/globals.ts Outdated

Comment thread src/commands/validate.ts Outdated

Comment thread src/commands/validate.ts Outdated

imabp and others added 4 commits February 9, 2022 13:52

fix: specfile to file

3ae7505

Co-authored-by: Lukasz Gornicki <lpgornicki@gmail.com>

fix: edit change message for watcher

24f55c7

Co-authored-by: Lukasz Gornicki <lpgornicki@gmail.com>

fix: change watch flag description

755e1ac

Co-authored-by: Lukasz Gornicki <lpgornicki@gmail.com>

feat: add watcher in diff

3f29110

imabp requested a review from derberg February 9, 2022 09:35

magicmatatjahu suggested changes Feb 9, 2022

View reviewed changes

Comment thread src/commands/validate.ts Outdated

Comment thread src/globals.ts Outdated

Comment thread src/globals.ts Outdated

imabp added 2 commits February 9, 2022 16:11

Merge branch 'master' of https://github.com/asyncapi/cli into imabp-w…

2458b90

…atch

fix: refactor watcher configuration

2cf0aa5

magicmatatjahu suggested changes Feb 9, 2022

View reviewed changes

fix: code smell

3f94bc9

fix: refactor watch command.

aa0db23

derberg suggested changes Feb 10, 2022

View reviewed changes

Comment thread src/commands/diff.ts Outdated

Comment thread src/flags.ts

imabp added 2 commits February 10, 2022 15:44

feat: auto-disable watch mode for web URLs

5cae99b

Merge branch 'master' into imabp-watch

bef53f7

imabp added 2 commits February 10, 2022 16:00

fix: merge conflicts

71afd18

fix: update log messages

a91f94d

imabp requested review from derberg and magicmatatjahu February 10, 2022 10:44

derberg suggested changes Feb 10, 2022

View reviewed changes

Comment thread src/globals.ts Outdated

Comment thread src/globals.ts Outdated

Comment thread src/globals.ts Outdated

magicmatatjahu reviewed Feb 10, 2022

View reviewed changes

Comment thread src/globals.ts Outdated

Comment thread src/flags.ts

fix: change log color

15d58ca

Co-authored-by: Lukasz Gornicki <lpgornicki@gmail.com>

imabp mentioned this pull request Feb 18, 2022

handling unhandledRejection for support of nodejs version < 15.x.x #234

Closed

feat: extend support for node versions

aa42efd

imabp requested a review from magicmatatjahu February 18, 2022 14:20

magicmatatjahu reviewed Feb 18, 2022

View reviewed changes

Comment thread src/commands/diff.ts Outdated

fix: refactor watcher

3b5651a

imabp requested a review from magicmatatjahu February 21, 2022 06:10

Merge branch 'master' into imabp-watch

64f57d0

magicmatatjahu approved these changes Feb 21, 2022

View reviewed changes

asyncapi-bot added the ready-to-merge label Feb 21, 2022

magicmatatjahu merged commit 1021b6b into asyncapi:master Feb 21, 2022

imabp mentioned this pull request Feb 21, 2022

Improve Logging by introducing Logger Interface #236

Closed

asyncapi-bot added the released label Feb 21, 2022

allcontributors Bot mentioned this pull request Feb 21, 2022

docs: add imabp as a contributor for code #239

Merged

imabp mentioned this pull request Mar 5, 2022

v1.0.0 planning #251

Closed

16 tasks

Uh oh!

Uh oh!

Conversation

imabp commented Feb 8, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

imabp commented Feb 9, 2022

Uh oh!

derberg left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

imabp commented Feb 9, 2022

Uh oh!

magicmatatjahu left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

magicmatatjahu left a comment

Choose a reason for hiding this comment

Uh oh!

imabp commented Feb 9, 2022

Uh oh!

derberg left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

imabp commented Feb 10, 2022

Uh oh!

derberg left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

imabp commented Feb 18, 2022

Uh oh!

imabp commented Feb 18, 2022

Uh oh!

magicmatatjahu commented Feb 18, 2022

Uh oh!

imabp commented Feb 18, 2022

Uh oh!

magicmatatjahu commented Feb 18, 2022

Uh oh!

imabp commented Feb 18, 2022

Uh oh!

imabp commented Feb 18, 2022

Uh oh!

magicmatatjahu left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

sonarqubecloud Bot commented Feb 21, 2022

Uh oh!

magicmatatjahu left a comment

Choose a reason for hiding this comment

Uh oh!

magicmatatjahu commented Feb 21, 2022

Uh oh!

imabp commented Feb 21, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

asyncapi-bot commented Feb 21, 2022

Uh oh!

imabp commented Feb 21, 2022

Uh oh!

allcontributors Bot commented Feb 21, 2022

Uh oh!

imabp commented Feb 21, 2022

Uh oh!

Reviewers

imabp commented Feb 8, 2022 •

edited

Loading

imabp commented Feb 21, 2022 •

edited

Loading