Add io::ErrorKind::TooManyOpenFiles#158326
Open
valentynkit wants to merge 1 commit into
Open
Conversation
`EMFILE` and `ENFILE` decoded to `ErrorKind::Uncategorized`, so running out of file descriptors could only be detected through `raw_os_error()`. Map them, and the equivalent codes on Windows (`ERROR_TOO_MANY_OPEN_FILES`, `WSAEMFILE`) and VEXos (`FR_TOO_MANY_OPEN_FILES`), to a new unstable `TooManyOpenFiles` variant.
Collaborator
|
A job failed! Check out the build log: (web) (plain enhanced) (plain) Click to see the possible cause of the failure (guessed by this bot) |
Member
|
@bors r+ rollup PR CI failure is spurious |
Contributor
4 tasks
jhpratt
added a commit
to jhpratt/rust
that referenced
this pull request
Jun 24, 2026
…-files, r=jhpratt Add `io::ErrorKind::TooManyOpenFiles` Adds an unstable `io::ErrorKind::TooManyOpenFiles` for the open-file-limit condition. `EMFILE` and `ENFILE` currently decode to `ErrorKind::Uncategorized`, so stable code cannot tell that an operation failed because the process or the system ran out of file descriptors without inspecting `raw_os_error()` and a platform-specific `libc`/`windows-sys` constant. Implements the accepted ACP rust-lang/libs-team#818, including its decision to collapse `EMFILE` and `ENFILE` into a single variant. Finer-grained handling stays available through `raw_os_error()`. The variant maps: - `EMFILE` / `ENFILE` on Unix and WASI - `ERROR_TOO_MANY_OPEN_FILES` / `WSAEMFILE` on Windows - `FR_TOO_MANY_OPEN_FILES` on VEXos Tracking issue: rust-lang#158319 r? libs
rust-bors Bot
pushed a commit
that referenced
this pull request
Jun 24, 2026
Rollup of 35 pull requests Successful merges: - #158315 (`rust-analyzer` subtree update) - #158336 (Stop excluding `stdarch` test crates from `rust-src`) - #155739 (Add temporary scope to assert_eq and assert_ne) - #156885 (Fix misattributed type inference error span for index expressions) - #157271 (simplify some `proc_macro` things) - #157419 (move rustc_type_ir Term things to term_kind.rs) - #157883 (Remove strict invariant node_type on hir_type during ty privacy visit) - #157921 (trait solver: Resolve region vars in max universe) - #157960 (delegation: add support for infers in generics) - #157983 (Lift the same-signature restriction for `extern "tail"`) - #158053 (Optimize network address parser) - #158105 (Extract all instance shim variants into new `ShimKind` enum) - #158207 (Resolver: local/external split of `resolve_ident_in_module_non_globs_unadjusted` ) - #158279 (Follow goto and drop when linting unreachable code) - #157527 (Move derive tests into their dedicated folder) - #157807 (don't ice on non-lifetime binders under `-Zassumptions-on-binders`) - #157939 (Reorganize `tests/ui/issues` [8/N]) - #157946 (Make `char::is_private_use` and `char::is_assigned` unstably public) - #158003 (Reorganize `tests/ui/issues` [9/N]) - #158020 (Update mingw-w64 C toolchain) - #158039 (c-variadic: test that we use equality up to free lifetimes) - #158060 (Reorganize `tests/ui/issues` [10/N]) - #158222 (format: ignore println newline in foreign format hints) - #158223 (Move target checking for #[lang] to the attribute parser) - #158252 (Use `cfg_select` in `std::os`) - #158263 (Only load the feature list once in the entire resolver) - #158267 (FromUtf8Error::into_utf8_lossy better example and suggest use) - #158272 (Reorganize `tests/ui/issues` [13/N]) - #158274 (triagebot: Stop pinging myself) - #158282 (slice_split_once: bounds check optimization note) - #158300 (Improve unknown crate_type diagnostic suggestions) - #158304 (mailmap: update mu001999) - #158309 (Update `rustc-literal-escaper` version to `0.0.8`) - #158314 (Fix incorrect unsafe debug assertion in unchecked_div_exact) - #158326 (Add `io::ErrorKind::TooManyOpenFiles`)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds an unstable
io::ErrorKind::TooManyOpenFilesfor the open-file-limit condition.EMFILEandENFILEcurrently decode toErrorKind::Uncategorized, so stable code cannot tell that an operation failed because the process or the system ran out of file descriptors without inspectingraw_os_error()and a platform-specificlibc/windows-sysconstant.Implements the accepted ACP rust-lang/libs-team#818, including its decision to collapse
EMFILEandENFILEinto a single variant. Finer-grained handling stays available throughraw_os_error().The variant maps:
EMFILE/ENFILEon Unix and WASIERROR_TOO_MANY_OPEN_FILES/WSAEMFILEon WindowsFR_TOO_MANY_OPEN_FILESon VEXosTracking issue: #158319
r? libs